From: SeerLite via Guix-patches via <guix-patches@gnu.org>
To: Maxime Devos <maximedevos@telenet.be>, 54221@debbugs.gnu.org
Subject: [bug#54221] [PATCH 3/4] gnu: vim: Update package style.
Date: Thu, 3 Mar 2022 13:49:44 -0300 [thread overview]
Message-ID: <dddd6d04-d69a-919b-1d92-e154fc5e1ce2@nixnet.email> (raw)
In-Reply-To: <6002b969ed2f353fef0e8fa87d4fc7d01d3344fa.camel@telenet.be>
Hi, thanks for the review!
On 3/2/22 14:29, Maxime Devos wrote:
> This is test stuff, and these binaries do not seem to be present in
> 'inputs', they would be in the implicit 'native-inputs', so these would
> need to search in '(or native-inputs inputs)' instead of 'inputs' to
> avoid &search-path exceptions when cross-compiling:
>
> (substitute* '("src/testdir/...")
> (("/bin/sh") (search-input-file (or native-inputs inputs) "bin/sh")))
>
> Or simpler, there's a procedure for looking for 'bin/TOOL' in native-
> inputs: 'which'!
>
> ;; the original code!
> (substitute* '("src/testdir/...")
> (("/bin/sh") (which "sh")))
Whoops, I forgot I made this change.
> Why the change from 'which' to 'search-input-file'?
The blog post that introduces label-less inputs also introduces
'search-input-file', which made me think they were both part of the
"package definition modernization process".
I asked on IRC if that was the case, and although I didn't get a clear
answer for that, someone told me they preferred using
'search-input-file' because it raises an exception when no file is found.
What do you think about that? Should I stick with 'search-input-file' or
is 'which' alright?
It makes sense that I'd have to use native-inputs though. My bad!
next prev parent reply other threads:[~2022-03-03 16:53 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 13:11 [bug#54221] [PATCH 0/4] vim: Detect plugins via search paths SeerLite via Guix-patches via
2022-03-02 13:17 ` [bug#54221] [PATCH 1/4] gnu: vim: Use native-search-paths to search for plugins SeerLite via Guix-patches via
2022-03-02 13:17 ` [bug#54221] [PATCH 2/4] gnu: neovim: Search and use installed plugins, like vim SeerLite via Guix-patches via
2022-03-02 18:30 ` Maxime Devos
2022-03-02 13:17 ` [bug#54221] [PATCH 3/4] gnu: vim: Update package style SeerLite via Guix-patches via
2022-03-02 18:25 ` Maxime Devos
2022-03-02 18:29 ` Maxime Devos
2022-03-03 16:49 ` SeerLite via Guix-patches via [this message]
2022-03-03 17:46 ` Maxime Devos
2022-03-02 18:35 ` Maxime Devos
2022-03-03 17:40 ` SeerLite via Guix-patches via
2022-03-16 14:16 ` [bug#54221] [PATCH 0/4] vim: Detect plugins via search paths Ludovic Courtès
2022-05-13 2:34 ` seerlite--- via Guix-patches via
2022-05-19 1:11 ` [bug#54221] [PATCH v4 2/2] gnu: neovim: Search and use installed plugins, like vim SeerLite via Guix-patches via
2022-03-02 13:17 ` [bug#54221] [PATCH 4/4] gnu: neovim: Update package style SeerLite via Guix-patches via
2022-03-02 18:40 ` Maxime Devos
2022-03-03 17:36 ` SeerLite via Guix-patches via
2022-03-02 18:33 ` [bug#54221] [PATCH 1/4] gnu: vim: Use native-search-paths to search for plugins Maxime Devos
2022-05-13 2:17 ` [bug#54221] [PATCH v2 1/2] " SeerLite via Guix-patches via
2022-05-13 2:17 ` [bug#54221] [PATCH v2 2/2] gnu: neovim: Search and use installed plugins, like vim SeerLite via Guix-patches via
2022-05-19 0:50 ` [bug#54221] [PATCH v3 1/2] gnu: vim: Use native-search-paths to search for plugins SeerLite via Guix-patches via
2022-05-19 0:50 ` [bug#54221] [PATCH v3 2/2] gnu: neovim: Search and use installed plugins, like vim SeerLite via Guix-patches via
2022-05-19 1:08 ` [bug#54221] [PATCH v4 1/2] gnu: vim: Use native-search-paths to search for plugins SeerLite via Guix-patches via
2022-05-19 1:08 ` [bug#54221] [PATCH v4 2/2] gnu: neovim: Search and use installed plugins, like vim SeerLite via Guix-patches via
2022-05-19 1:14 ` [bug#54221] [PATCH v5 1/2] gnu: vim: Use native-search-paths to search for plugins SeerLite via Guix-patches via
2022-05-19 1:14 ` [bug#54221] [PATCH v5 2/2] gnu: neovim: Search and use installed plugins, like vim SeerLite via Guix-patches via
2022-05-19 1:15 ` SeerLite via Guix-patches via
2022-05-24 0:41 ` [bug#54221] [PATCH v6 1/2] gnu: vim: Use native-search-paths to search for plugins SeerLite via Guix-patches via
2022-05-24 0:41 ` [bug#54221] [PATCH v6 2/2] gnu: neovim: Search and use installed plugins, like vim SeerLite via Guix-patches via
2022-05-24 1:52 ` [bug#54221] [PATCH v6 1/2] gnu: vim: Use native-search-paths to search for plugins SeerLite via Guix-patches via
2023-02-22 20:07 ` [bug#54221] [PATCH " SeerLite via Guix-patches via
2023-02-22 20:07 ` [bug#54221] [PATCH 2/2] gnu: neovim: Search and use installed plugins, like vim SeerLite via Guix-patches via
2023-08-05 12:34 ` Liliana Marie Prikler
2023-08-05 12:28 ` [bug#54221] [PATCH 1/2] gnu: vim: Use native-search-paths to search for plugins Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dddd6d04-d69a-919b-1d92-e154fc5e1ce2@nixnet.email \
--to=guix-patches@gnu.org \
--cc=54221@debbugs.gnu.org \
--cc=maximedevos@telenet.be \
--cc=seerlite@nixnet.email \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.