From: Maxime Devos <maximedevos@telenet.be>
To: 57840@debbugs.gnu.org
Cc: nicolas goaziou <mail@nicolasgoaziou.fr>
Subject: bug#57840: rust-sqlite3-src bundles sqlite3
Date: Thu, 15 Sep 2022 23:22:09 +0200 [thread overview]
Message-ID: <d98e6721-7fcc-8b13-db36-13c66ee08397@telenet.be> (raw)
[-- Attachment #1.1.1: Type: text/plain, Size: 1392 bytes --]
X-Debbugs-CC: Aleksandr Vityazev <avityazev@posteo.org>
X-Debbugs-CC: Nicolas Goaziou <mail@nicolasgoaziou.fr>
(^ the pseudo-header, IIUC)
The patch series 53315 by Aleksandr Vityazev and accepted by Nicolas
Goaziou adds a crate rust-sqlite3-src that bundles sqlite3.
Bundling is against Guix policy for the reasons explained in the manual
I ask to:
(a) Remove the bundled copy (and if needed, adjust build.rs to always
do the pkg-config)
or
(b) Remove rust-sqlite3-src and dependents.
Additionally, for the future, I ask to check packages for bundling, and
recommend the following tricks for detecting bundling:
* if a crate name ends with -sys, there is a good chance it bundles
things
* likewise, if the synopsis or description mentions 'Bindings',
there's a good chance it bundles things.
* if a crate name contains some variation of the word 'source'
(e.g., -src), that can indicate bundling.
* if the Cargo.toml mentions 'bundled', 'system' or 'vendor' its
[features], it is bundling things.
* if the source code of a Rust package contains a .c or .h file,
it's likely bundling things
I would like to note that the bundled copy (version 3.34.1) has known
bugs that were fixed in later versions (including a CVE), according to
the changelog on the sqlite website.
Greetings,
Maxime
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
next reply other threads:[~2022-09-15 21:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 21:22 Maxime Devos [this message]
2022-09-16 10:33 ` bug#57840: rust-sqlite3-src bundles sqlite3 Maxime Devos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d98e6721-7fcc-8b13-db36-13c66ee08397@telenet.be \
--to=maximedevos@telenet.be \
--cc=57840@debbugs.gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.