From: Pierre Langlois <pierre.langlois@gmx.com>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 29386-done@debbugs.gnu.org
Subject: [bug#29386] Update taglib to 1.11.1.
Date: Tue, 21 Nov 2017 21:29:08 +0000 [thread overview]
Message-ID: <cubr2sr1ftn.fsf@gmx.com> (raw)
In-Reply-To: <8760a3qq7p.fsf@fastmail.com>
Marius Bakke writes:
> Pierre Langlois <pierre.langlois@gmx.com> writes:
>
>> Hello Guix!
>>
>> This is a patch to update taglib. I've had to enable building
>> as a
>> shared library otherwise gst-plugins-good would fail to
>> link. Also,
>> `guix lint' warned about the home page redirecting to
>> http://taglib.org
>> so I thought I'd fix that too.
>
> Hello Pierre,
>
> Thank you for this patch, and for checking dependent packages!
> I've
> applied it after fixing a typo in the commit message (home
> page).
>
>> Finally, I tried to enable the tests by adding "-DBUILD_TESTS"
>> as a
>> configure flag but they are explicitely disabled if building
>> the shared
>> library:
>> ~~~
>> if(BUILD_TESTS AND NOT BUILD_SHARED_LIBS)
>> enable_testing()
>> add_subdirectory(tests)
>> endif()
>> ~~~
>>
>> Oh well, how does this look?
>
> OK! Perhaps we could do a separate build just for the tests,
> but that
> should be in a standalone patch anyway.
>
> Pushed as d1451fa0d0b27a20ef3a1b3fe8d53a995f0c4d85.
That was quick! Thank you!
Pierre
prev parent reply other threads:[~2017-11-21 21:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 21:11 [bug#29386] Update taglib to 1.11.1 Pierre Langlois
2017-11-21 21:25 ` bug#29386: " Marius Bakke
2017-11-21 21:29 ` Pierre Langlois [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cubr2sr1ftn.fsf@gmx.com \
--to=pierre.langlois@gmx.com \
--cc=29386-done@debbugs.gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.