From: Arun Isaac <arunisaac@systemreboot.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 33801@debbugs.gnu.org
Subject: [bug#33801] import: github: Support source URIs that redirect to GitHub
Date: Mon, 07 Jan 2019 23:18:11 +0530 [thread overview]
Message-ID: <cu78szw8ilg.fsf@systemreboot.net> (raw)
In-Reply-To: <87o98uzo9u.fsf@gnu.org>
[-- Attachment #1.1: Type: text/plain, Size: 632 bytes --]
> I just realized that the warning also triggers when the URL is already a
> github.com URL:
> --8<---------------cut here---------------start------------->8---
> $ ./pre-inst-env guix lint -c github-uri stellarium
> gnu/packages/astronomy.scm:135:12: stellarium@0.18.1: URL should be 'https://github.com/Stellarium/stellarium/releases/download/v0.18.1/stellarium-0.18.1.tar.gz'
> --8<---------------cut here---------------end--------------->8---
This is a simple mistake on my part and it's not because stellarium's
origin URI redirects to the github-production-release-asset URI. Please
find attached a patch addressing this.
[-- Attachment #1.2: 0001-guix-lint-Warn-only-if-GitHub-URI-is-not-same-as-the.patch --]
[-- Type: text/x-patch, Size: 1680 bytes --]
From a8bc92f507e35b54afdd24a42f0aa45ff7cb2c0b Mon Sep 17 00:00:00 2001
From: Arun Isaac <arunisaac@systemreboot.net>
Date: Mon, 7 Jan 2019 23:11:58 +0530
Subject: [PATCH] guix: lint: Warn only if GitHub URI is not same as the
package URI.
* guix/scripts/lint.scm (check-github-url): Warn only if the GitHub URI
obtained after following redirects is not same as the original URI.
---
guix/scripts/lint.scm | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm
index 9acec4857..0f315a935 100644
--- a/guix/scripts/lint.scm
+++ b/guix/scripts/lint.scm
@@ -8,7 +8,7 @@
;;; Copyright © 2017 Alex Kost <alezost@gmail.com>
;;; Copyright © 2017 Tobias Geerinckx-Rice <me@tobias.gr>
;;; Copyright © 2017, 2018 Efraim Flashner <efraim@flashner.co.il>
-;;; Copyright © 2018 Arun Isaac <arunisaac@systemreboot.net>
+;;; Copyright © 2018, 2019 Arun Isaac <arunisaac@systemreboot.net>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -820,10 +820,11 @@ descriptions maintained upstream."
(lambda (uri)
(and=> (follow-redirects-to-github uri)
(lambda (github-uri)
- (emit-warning
- package
- (format #f (G_ "URL should be '~a'") github-uri)
- 'source))))
+ (unless (string=? github-uri uri)
+ (emit-warning
+ package
+ (format #f (G_ "URL should be '~a'") github-uri)
+ 'source)))))
(origin-uris origin)))))
(define (check-derivation package)
--
2.19.2
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2019-01-07 17:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-19 10:44 [bug#33801] import: github: Support source URIs that redirect to GitHub Arun Isaac
2018-12-19 21:47 ` Ludovic Courtès
2018-12-20 6:56 ` Arun Isaac
2018-12-20 10:55 ` Ludovic Courtès
2018-12-20 11:20 ` Arun Isaac
2018-12-20 11:22 ` Ludovic Courtès
2018-12-20 13:07 ` Arun Isaac
2018-12-20 16:28 ` Ludovic Courtès
2018-12-20 16:48 ` Arun Isaac
2018-12-21 12:27 ` Arun Isaac
2018-12-21 15:18 ` Ludovic Courtès
2018-12-22 10:08 ` Arun Isaac
2018-12-23 17:23 ` Ludovic Courtès
2019-01-05 23:18 ` Ludovic Courtès
2019-01-07 17:48 ` Arun Isaac [this message]
2019-01-08 8:40 ` Ludovic Courtès
2019-01-08 13:19 ` Arun Isaac
2019-01-09 14:11 ` bug#33801: " Ludovic Courtès
2019-01-10 7:45 ` [bug#33801] " Arun Isaac
2019-01-10 8:52 ` Ludovic Courtès
2019-01-10 10:12 ` Arun Isaac
2018-12-21 0:12 ` Eric Bavier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cu78szw8ilg.fsf@systemreboot.net \
--to=arunisaac@systemreboot.net \
--cc=33801@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.