From: gemmaro <gemmaro.dev@gmail.com>
To: 60424@debbugs.gnu.org
Cc: gemmaro <gemmaro.dev@gmail.com>
Subject: [bug#60424] [PATCH 0/2] gnu: Add online-judge-tools
Date: Sat, 7 Jan 2023 18:33:08 +0900 [thread overview]
Message-ID: <cover.1673081398.git.gemmaro.dev@gmail.com> (raw)
In-Reply-To: <e0227b25ac1950922c869ea6f6f8dae1a8033b60.1672377617.git.gemmaro.dev@gmail.com>
Hello,
This revised patch series add online-judge-tools (`oj' command), which helps
solving problems on various online judges.
> general notes: Please split your changes into one patch per package and
> add changelog-style commit messages.
My apologies.
I split into two paches per package and add commit messages for each.
> > + ;; NOTE: somehow it cannot be downloaded from PyPI
> Why did it fail?
It was because the both packages doesn't have source distributions on PyPI.
I added comments for this.
> > + ;; NOTE: a lot of tests needs networking
> > + `(#:tests? #f))
> Is it possible to disable just the ones that require networking instead
> of disabling all tests?
I changed to disable only failed test cases.
One assertion in the test case on the `online-judge-tools` (at the end of
`online-judge-tools.patch`) doesn't pass, so I commented it out. I am not sure
of the cause, but this would not be a problem in normal use.
> It looks like this one provides a command-line tool called `oj`, so
> the package should be named `oj` or just `online-judge-tools` without
> python- prefix.
I renamed it to `online-judge-tools`.
I have also added the `time` package as input for `online-judge-tools`.
GNU Time is used by the `oj test` command.
Sincerely,
gemmaro
gemmaro (2):
gnu: Add python-online-judge-api-client
gnu: Add online-judge-tools
gnu/packages/patches/online-judge-tools.patch | 62 +++
...python-online-judge-api-client-tests.patch | 429 ++++++++++++++++++
gnu/packages/python-xyz.scm | 97 ++++
3 files changed, 588 insertions(+)
create mode 100644 gnu/packages/patches/online-judge-tools.patch
create mode 100644 gnu/packages/patches/python-online-judge-api-client-tests.patch
base-commit: ddebb5c5634fcfbec9571453f2db72b238d73e75
--
2.38.1
next prev parent reply other threads:[~2023-01-07 9:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-30 5:20 [bug#60424] [PATCH] gnu: Add python-online-judge-tools gemmaro
2023-01-04 8:46 ` Lars-Dominik Braun
2023-01-07 9:33 ` gemmaro [this message]
2023-01-07 9:33 ` [bug#60424] [PATCH 1/2] gnu: Add python-online-judge-api-client gemmaro
2023-01-07 9:33 ` [bug#60424] [PATCH 2/2] gnu: Add online-judge-tools gemmaro
2023-03-03 9:08 ` Josselin Poiret via Guix-patches via
2023-03-03 14:52 ` [bug#60424] [PATCH v3 0/2] " gemmaro
2023-03-03 14:52 ` [bug#60424] [PATCH v3 1/2] gnu: Add python-online-judge-api-client gemmaro
2023-03-03 14:52 ` [bug#60424] [PATCH v3 2/2] gnu: Add online-judge-tools gemmaro
2023-05-03 4:39 ` [bug#60424] [PATCH v4 0/2] gnu: Add python-online-judge-tools gemmaro
2023-05-03 4:39 ` [bug#60424] [PATCH v4 1/2] gnu: Add python-online-judge-api-client gemmaro
2023-05-03 4:39 ` [bug#60424] [PATCH v4 2/2] gnu: Add online-judge-tools gemmaro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1673081398.git.gemmaro.dev@gmail.com \
--to=gemmaro.dev@gmail.com \
--cc=60424@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.