From: Bruno Victal <mirai@makinata.eu>
To: Simon Tournier <zimon.toutoune@gmail.com>
Cc: 62000@debbugs.gnu.org
Subject: bug#62000: Inconsistent indentation rules for define-configuration
Date: Tue, 7 Mar 2023 13:54:41 +0000 [thread overview]
Message-ID: <cd0c7b2b-b0c8-7c82-9558-7561183fdc9e@makinata.eu> (raw)
In-Reply-To: <86ilfcbt12.fsf@gmail.com>
Hi Simon,
On 2023-03-07 13:16, Simon Tournier wrote:
> Hi,
>
> Cool you had the number 62000. ;-)
>
> On Mon, 06 Mar 2023 at 12:48, Bruno Victal <mirai@makinata.eu> wrote:
>> Suspected file: .dir-locals.el
>>
>> Using 'package' as a field in define-configuration results in
>> inconsistent indentation:
>>
>> --8<---------------cut here---------------start------------->8---
>> (define-configuration/no-serialization mympd-configuration
>> (package
>> (file-like mympd) ;;;; <<<<<<<<<<<<<<<<<<<<< notice how it's indented with 2 spaces
>> "The package object of the myMPD server."
>> empty-serializer)
>>
>> (shepherd-requirement
>> (list-of-symbol '()) ;;;; <<<<<<<<<<<<<<<<<<<<< vs 1 space
>> "This is a list of symbols naming Shepherd services that this service
>> will depend on."
>> empty-serializer)
>>
>> ;; ...
>> )
>> --8<---------------cut here---------------end--------------->8---
>
> What do you mean by inconsistent? Do you think that
> ’sheperd-requirement’ should be management by .dir-locals.el?
It's not 'shepherd-requirement' that should be managed by .dir-locals.el, it could have been named something else.
Compare with 'mympd-ip-acl':
--8<---------------cut here---------------start------------->8---
(define-configuration/no-serialization mympd-ip-acl
(allow
(list-of-string '())
"Allowed IP addresses.")
(deny
(list-of-string '())
"Disallowed IP addresses."))
--8<---------------cut here---------------end--------------->8---
It's uniformly indented.
> Well, since ’sheperd-requirement’ is not in .dir-locals.el, the
> indentation seems expected. What do you consider as a bug?
Having a field named 'package' within define-configuration causes incorrect indentation.
Cheers,
Bruno.
next prev parent reply other threads:[~2023-03-07 13:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 12:48 bug#62000: Inconsistent indentation rules for define-configuration Bruno Victal
2023-03-07 13:16 ` Simon Tournier
2023-03-07 13:54 ` Bruno Victal [this message]
2023-03-07 14:02 ` Simon Tournier
2023-06-22 13:40 ` Bruno Victal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd0c7b2b-b0c8-7c82-9558-7561183fdc9e@makinata.eu \
--to=mirai@makinata.eu \
--cc=62000@debbugs.gnu.org \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.