all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: Z572 <873216071@qq.com>, 52181@debbugs.gnu.org
Subject: bug#52181: [core-update-frozen] many rust package can't build because them source file-name use ".crate" suffix.
Date: Mon, 29 Nov 2021 19:16:29 +0000	[thread overview]
Message-ID: <c45f8f34893ff89b233c4abf31be150a335ca43b.camel@telenet.be> (raw)
In-Reply-To: <87o863owrp.fsf@qq.com>

Z572 via Bug reports for GNU Guix schreef op ma 29-11-2021 om 22:31
[+0800]:
> I think have 2 option:
> 
>  1. change suffix from ".crate" to ".tar.gz".
>  2. maybe let "tarball?" check file like command-line program "file",
> no
>  just check filename suffix.

A third option: let tarball? recognise ".crate" suffixes.
A hacky fourth option (to avoid a full world-rebuild):
in cargo-build, do:

;; Untested, might not work due to inlining.

;; XXX: modify tarball? on the next world-rebuild
(define tarball?/fixed
  (let ((tarball?/old tarball?))
    (lambda (filename)
      (or (tarball? filename)
          (string-suffix? ".crate" filename)))))

(define* (cargo-build ...)
  (set! tarball? tarball?/fixed)
  (apply gnu:gnu-build ...))

The second option would be a bit complicated to do efficiently, because
the tar would be wrapped inside a gzip/xzip/..., unless it is
acceptable for tarball? to assume that every gzipped/... file is a
gzipped/... tarball.

Greetings,
Maxime.





  parent reply	other threads:[~2021-11-29 19:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-29 14:31 bug#52181: [core-update-frozen] many rust package can't build because them source file-name use ".crate" suffix Z572 via Bug reports for GNU Guix
2021-11-29 14:31 ` Z572 via Bug reports for GNU Guix
2021-11-29 19:16 ` Maxime Devos [this message]
2021-11-29 19:34   ` Maxime Devos
2021-11-30 13:45 ` Efraim Flashner
2021-12-01 13:15   ` Z572 via Bug reports for GNU Guix
2021-12-01 13:15     ` Z572 via Bug reports for GNU Guix
2021-12-02  8:36     ` Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c45f8f34893ff89b233c4abf31be150a335ca43b.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=52181@debbugs.gnu.org \
    --cc=873216071@qq.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.