From: Vinicius Monego <monego@posteo.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Vivien <vivien@planete-kraus.eu>, 53402@debbugs.gnu.org
Subject: [bug#53402] Add python-mne
Date: Wed, 9 Mar 2022 23:28:00 +0000 [thread overview]
Message-ID: <c36dad4e-05df-c822-f36f-6b8180fcbeb0@posteo.net> (raw)
In-Reply-To: <87bkyiiwg2.fsf_-_@gnu.org>
On 06/03/2022 6:48 PM, Ludovic Courtès wrote:
> Hello!
>
> Vinicius, could you take a look at v5 of this patch series?
>
> Thanks for reviewing!
>
> Ludo’.
Hi Ludo, Vivien.
Sorry for the long wait. I will be busy until mid-April. I did review
the patches earlier and LGTM apart from minor style/lint and description
issues, but I could fix that before committing. I saw that someone
pushed a wip-python-mne branch and thought they were taking care of this.
I have some questions for other maintainers, like
1. Is it OK to have that many bootstrap packages for pytest modules
(patches 8 to 16) and in files different than where they are supposed to
be (e.g. decopatch-minimal in python-check to bootstrap pytest-harvest)?
It seems that there are no other options in this case though.
2. Should python-no-verison (patch 22) be a public variable? It is an
example package, doesn't seem to be useful to expose it.
If it's OK I could push the series up to patch 26. I haven't reviewed 27
and on in v5.
3. Not a question but it would be good to review FSDG status of
python-mne, since it contains code to download non-free data.
next prev parent reply other threads:[~2022-03-09 23:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 22:46 [bug#53402] Add python-mne Vivien via Guix-patches via
[not found] ` <handler.53402.B.164271885411910.ack@debbugs.gnu.org>
2022-01-21 8:17 ` [bug#53402] Add python-mne: fix or disable tests Vivien Kraus via Guix-patches via
2022-02-03 19:29 ` [bug#53402] Rebase it for the new python packages Vivien via Guix-patches via
2022-02-03 20:49 ` Vinicius Monego
2022-02-06 14:49 ` Vivien via Guix-patches via
2022-02-06 20:06 ` Vinicius Monego
2022-02-11 3:03 ` Vivien via Guix-patches via
2022-03-06 21:48 ` [bug#53402] Add python-mne Ludovic Courtès
2022-03-09 23:28 ` Vinicius Monego [this message]
2022-05-26 21:24 ` [bug#53402] Update dependencies and rebase on newer work Vivien Kraus via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c36dad4e-05df-c822-f36f-6b8180fcbeb0@posteo.net \
--to=monego@posteo.net \
--cc=53402@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=vivien@planete-kraus.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.