From: Hartmut Goebel <h.goebel@crazy-compilers.com>
To: mike.rosset@gmail.com, Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org, GNU Guix maintainers <guix-maintainers@gnu.org>
Subject: Re: qtwenengine anybody?
Date: Tue, 7 Jan 2020 11:26:20 +0100 [thread overview]
Message-ID: <bc1068e1-c909-f1b8-8c6e-5c33e9f6224b@crazy-compilers.com> (raw)
In-Reply-To: <871rsccdq8.fsf@gmail.com>
Am 07.01.20 um 01:27 schrieb mike.rosset@gmail.com:
>
>> With these changes, I think the package is ready to go. \o/
> This is really great work Marius I appreciate this addition. I was
> actually just looking at this approach yesterday.
>
> I've merged your two patches with one minor description addition that Hartmut
> requested.
Great work you've done! I'm looking forward to get this merged to
master, so I can continue working on some more KDE packages.
> Hartmut the merged complete diff can be found here.
> https://gitlab.com/mike.rosset/guix/compare/master...merge-qtwebengine
Fine for me.
Just some super-nitpicky nitpicks:
> + (base32
> +
> "08c60nh95m98mcqk444axs76xi6m9x0wvdxrzk9c2cxwqdbz59fa"))))
Maybe move has into `base32` line
> + (define (third-party? file)
> + (if (string-contains file "third_party/")
> + #t
> + #f))
The "if" could be omitted, I assume
--
Regards
Hartmut Goebel
| Hartmut Goebel | h.goebel@crazy-compilers.com |
| www.crazy-compilers.com | compilers which you thought are impossible |
next prev parent reply other threads:[~2020-01-07 10:26 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 12:55 qtwenengine anybody? Hartmut Goebel
2019-12-16 13:42 ` Pierre Neidhardt
2019-12-16 14:13 ` mike.rosset
2019-12-16 14:15 ` Pierre Neidhardt
2019-12-16 15:19 ` mike.rosset
2019-12-16 15:22 ` Hartmut Goebel
2019-12-16 15:45 ` mike.rosset
2019-12-16 15:57 ` Hartmut Goebel
2019-12-16 17:09 ` mike.rosset
2019-12-16 17:29 ` Hartmut Goebel
2019-12-18 21:24 ` mike.rosset
2019-12-18 22:03 ` Pierre Neidhardt
2019-12-18 22:30 ` mike.rosset
2019-12-19 18:23 ` Pierre Neidhardt
2019-12-19 19:47 ` mike.rosset
2019-12-19 20:36 ` Pierre Neidhardt
2019-12-20 0:16 ` mike.rosset
2019-12-20 10:46 ` Pierre Neidhardt
2019-12-20 10:53 ` Pierre Neidhardt
2019-12-20 15:52 ` [bug#35866] [PATCH 2/2] gnu: qtwebengine now uses pulseaudio Mike Rosset
2019-12-18 22:46 ` qtwenengine anybody? Ricardo Wurmus
2019-12-20 10:49 ` Pierre Neidhardt
2019-12-20 16:04 ` mike.rosset
2019-12-20 16:16 ` Pierre Neidhardt
2019-12-20 16:44 ` mike.rosset
2019-12-31 13:48 ` Pierre Neidhardt
2019-12-31 13:50 ` Pierre Neidhardt
2020-01-01 17:34 ` mike.rosset
2020-01-01 20:43 ` Pierre Neidhardt
2020-01-01 22:30 ` mike.rosset
2020-01-02 12:29 ` Hartmut Goebel
2020-01-02 20:24 ` mike.rosset
2020-01-03 14:57 ` Hartmut Goebel
2020-01-05 16:10 ` mike.rosset
2020-01-05 16:47 ` Hartmut Goebel
2020-01-05 16:47 ` [bug#35866] " Hartmut Goebel
2020-01-01 22:46 ` Ricardo Wurmus
2020-01-02 10:52 ` Pierre Neidhardt
2020-01-05 14:59 ` mike.rosset
2020-01-05 19:52 ` Ricardo Wurmus
2020-01-06 5:11 ` mike.rosset
2020-01-06 19:23 ` Marius Bakke
2020-01-07 0:27 ` mike.rosset
2020-01-07 10:26 ` Hartmut Goebel [this message]
2020-01-07 19:28 ` mike.rosset
2020-01-11 17:39 ` Marius Bakke
2020-01-11 17:40 ` Pierre Neidhardt
2020-01-11 18:19 ` Mike Rosset
2020-01-11 18:28 ` Pierre Neidhardt
2020-01-13 10:54 ` Mike Rosset
2020-01-13 14:26 ` Pierre Neidhardt
2020-01-13 18:37 ` Mike Rosset
2020-01-11 18:14 ` Mike Rosset
2020-01-07 8:09 ` Pierre Neidhardt
2020-01-07 19:14 ` mike.rosset
2020-01-07 8:12 ` Pierre Neidhardt
2020-01-07 22:49 ` Marius Bakke
2020-01-01 17:22 ` mike.rosset
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc1068e1-c909-f1b8-8c6e-5c33e9f6224b@crazy-compilers.com \
--to=h.goebel@crazy-compilers.com \
--cc=guix-devel@gnu.org \
--cc=guix-maintainers@gnu.org \
--cc=mbakke@fastmail.com \
--cc=mike.rosset@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.