all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: Attila Lendvai <attila@lendvai.name>, 54207@debbugs.gnu.org
Subject: [bug#54207] [PATCH] gnu: shepherd: Convert to build from git instead of a release.
Date: Tue, 01 Mar 2022 11:18:59 +0100	[thread overview]
Message-ID: <bb1efdbf41460cf19760f656cd9ac185804f6325.camel@telenet.be> (raw)
In-Reply-To: <20220301085912.31958-1-attila@lendvai.name>

[-- Attachment #1: Type: text/plain, Size: 1154 bytes --]

Attila Lendvai schreef op di 01-03-2022 om 09:59 [+0100]:
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://git.savannah.gnu.org/git/shepherd.git/")
> +             (commit (string-append "v" version))))

Perhaps add a comment about why it a git origin is used
and autoconf & friends are in native-inputs?

  ;; Build from git and add Autotools inputs, to make developing
  ;; the shepherd easier

Also, to avoid having to go through staging for adding a feature
to the shepherd to use in Guix, WDYT of defining a package variant
of shepherd for use in Guix, and modifying the default Guix in
'shepherd-configuration' appropriately?

(define-public shepherd-for-guix
  (let ((commit ...)
        (revision ...))
    (package
      (inherit shepherd)
      (source [the git origin])
      (version (git-version ...))
      (native-inputs
        (modify-inputs (package-inputs shepherd)
          (prepend [autotools packages])))
      (description [a package variant for use in Guix]))))

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

  parent reply	other threads:[~2022-03-01 10:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-01  8:59 [bug#54207] [PATCH] gnu: shepherd: Convert to build from git instead of a release Attila Lendvai
2022-03-01  9:09 ` [bug#54207] (No Subject) Attila Lendvai
2022-03-01 10:18 ` Maxime Devos [this message]
2022-03-01 18:49 ` bug#54207: " Attila Lendvai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb1efdbf41460cf19760f656cd9ac185804f6325.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=54207@debbugs.gnu.org \
    --cc=attila@lendvai.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.