all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: Arun Isaac <arunisaac@systemreboot.net>, 54471@debbugs.gnu.org
Subject: [bug#54471] [PATCH core-updates 0/2] font-build-system: Install web fonts
Date: Sun, 20 Mar 2022 12:27:59 +0100	[thread overview]
Message-ID: <b3233aba35e714a265b957cf729edf49f595e0fe.camel@telenet.be> (raw)
In-Reply-To: <20220320110043.18099-1-arunisaac@systemreboot.net>

[-- Attachment #1: Type: text/plain, Size: 1128 bytes --]

Arun Isaac schreef op zo 20-03-2022 om 16:30 [+0530]:
> Currently, we don't install the woff and woff2 web fonts in our font build
> system. The first patch fixes that. The second patches removes the return of
> #t from phases.

font-build-system currently puts "tar", "gzip", "bzip2", "unzip" (*),
and "xz" in 'host-inputs' (the build system equivalent of 'inputs')
instead of 'build-inputs' (the build system equivalent of 'native-
inputs'), which is wrong when cross-compiling.

For font-build-system, this does not truly matter, since #:target is
ignored for font-build-system.  However, to avoid accidentally teaching
people to accidentally mess up the inputs/native-inputs difference and
instead give the right example, WDYT of moving "tar" and friends to
'build-inputs'?

It's technically a separate thing from your patches, but I think it
would be nice to bundle multiple core-updates changes together (in
separate patches, but in a same ‘push’).

(*) The location of 'source' does not matter since sources are
(currently) assumed to be architecture-independent in Guix.

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

  parent reply	other threads:[~2022-03-20 11:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-20 11:00 [bug#54471] [PATCH core-updates 0/2] font-build-system: Install web fonts Arun Isaac
2022-03-20 11:02 ` [bug#54471] [PATCH core-updates 1/2] build: " Arun Isaac
2022-03-20 11:02   ` [bug#54471] [PATCH core-updates 2/2] build: font-build-system: Do not return #t from phases Arun Isaac
2022-03-20 11:27 ` Maxime Devos [this message]
2022-03-21 12:17   ` [bug#54471] [PATCH core-updates 0/2] font-build-system: Install web fonts Arun Isaac
2022-03-21 12:17   ` [bug#54471] [PATCH core-updates v2 1/3] build: " Arun Isaac
2022-03-21 12:17   ` [bug#54471] [PATCH core-updates v2 2/3] build: font-build-system: Do not return #t from phases Arun Isaac
2022-03-21 12:17   ` [bug#54471] [PATCH core-updates v2 3/3] build-system: font: Move unpack utilities to build-inputs Arun Isaac
2022-04-09 15:56     ` Arun Isaac
2022-04-09 16:03       ` Maxime Devos
2022-04-09 16:04       ` Maxime Devos
2022-04-09 16:54         ` Arun Isaac
2022-05-15 18:06           ` [bug#54471] [PATCH core-updates 0/2] font-build-system: Install web fonts Ludovic Courtès
2022-05-16  9:44             ` bug#54471: " Arun Isaac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b3233aba35e714a265b957cf729edf49f595e0fe.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=54471@debbugs.gnu.org \
    --cc=arunisaac@systemreboot.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.