all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: paul via Guix-patches via <guix-patches@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 66396@debbugs.gnu.org
Subject: [bug#66396] [PATCH] guix: Add case to Github url updater.
Date: Tue, 24 Oct 2023 00:05:04 +0200	[thread overview]
Message-ID: <b201ae55-5311-b1a5-05aa-f9291f8253ce@autistici.org> (raw)
In-Reply-To: <87y1ftc8bu.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 791 bytes --]

Hi Ludo’ ,

On 10/23/23 23:55, Ludovic Courtès wrote:
>> +           ((string-match (string-append "/releases/download/(v)?" version "/"
>> +                                         name ".*" ext "$")
>> +                          url)
>> +            (string-replace-substring url version new-version))
> Is it not already covered by one of the other cases?  Do you have an
> example URL matched by this new clause?
Yes, this patch fixes some failings I got from urls such as:

|https://github.com/derailed/k9s/releases/download/v||0.27.4||/k9s_Linux_amd64.tar.gz|

|https://github.com/metal3d/katenary/releases/download/||2.0.0-beta2||/katenary-linux-amd64|

|https://github.com/kubernetes/kompose/releases/download/v||1.30.0||/kompose-linux-amd64|


Thank you for your time,


giacomo

[-- Attachment #2: Type: text/html, Size: 1704 bytes --]

  reply	other threads:[~2023-10-23 22:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-07 19:45 [bug#66396] [PATCH] guix: Add case to Github url updater Giacomo Leidi via Guix-patches via
2023-10-23 21:55 ` Ludovic Courtès
2023-10-23 22:05   ` paul via Guix-patches via [this message]
2023-12-03 22:03     ` paul via Guix-patches via
2024-02-07  0:50       ` paul via Guix-patches via
2024-04-17  9:12         ` bug#66396: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b201ae55-5311-b1a5-05aa-f9291f8253ce@autistici.org \
    --to=guix-patches@gnu.org \
    --cc=66396@debbugs.gnu.org \
    --cc=goodoldpaul@autistici.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.