all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Roman Scherer <roman@burningswell.com>
To: 68484@debbugs.gnu.org
Cc: Roman Scherer <roman@burningswell.com>
Subject: [bug#68484] [PATCH v2] gnu: guile-fibers: Disable failing tests on aarch64.
Date: Wed, 17 Jan 2024 20:48:36 +0100	[thread overview]
Message-ID: <b02a6b5855a3c9281574ce96cb57bd383cb90593.1705520751.git.roman@burningswell.com> (raw)
In-Reply-To: <d7961d2119012fd17284604ccde2d242d16ee1dd.1705348597.git.roman@burningswell.com>

* gnu/packages/guile-xyz.scm (guile-fibers): Disable failing tests on aarch64.

Change-Id: Id05b516a659f641cc7ef01efdaf6cd1f2c735800
---
 gnu/packages/guile-xyz.scm | 25 +++++++++++++++++++------
 1 file changed, 19 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 77be632cc3..1db0984a04 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -823,17 +823,30 @@ (define-public guile-fibers
      (list #:make-flags
            #~(list "GUILE_AUTO_COMPILE=0")
            #:phases
-           (if (target-x86-64?)
-             #~%standard-phases
-             #~(modify-phases %standard-phases
-                 (add-before 'check 'disable-some-tests
-                   (lambda _
+           #~(modify-phases %standard-phases
+               (add-before 'check 'disable-some-tests
+                 (lambda _
+                   (unless #$(target-x86-64?)
                      ;; This test can take more than an hour on some systems.
                      (substitute* "tests/basic.scm"
                        ((".*spawn-fiber loop-to-1e4.*") ""))
+
                      ;; These tests can take more than an hour and/or segfault.
                      (substitute* "Makefile"
-                       (("tests/speedup.scm") ""))))))))
+                       (("tests/speedup.scm") "")))
+
+                   (when #$(target-aarch64?)
+                     ;; This test has issues on aarch64 systems. It passes on
+                     ;; an Apple M1, but takes a very long time on a Hetzner
+                     ;; aarch64 VM.
+                     (substitute* "tests/basic.scm"
+                       ((".*spawn-fiber-chain 5000000.*") ""))
+
+                     ;; This test has issues on aarch64 systems. It passes on
+                     ;; an Apple M1, but raises exceptions on a Hetzner
+                     ;; aarch64 VM.
+                     (substitute* "tests/channels.scm"
+                       ((".*assert-run-fibers-terminates .*pingpong.*") ""))))))))
     (native-inputs
      (list texinfo pkg-config autoconf-2.71 automake libtool
            guile-3.0            ;for 'guild compile

base-commit: 162d6a2fdd6af13272967c77347a54934ecb45e6
-- 
2.41.0





  parent reply	other threads:[~2024-01-17 19:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-15 19:57 [bug#68484] [PATCH] gnu: guile-fibers: Disable failing tests on aarch64 Roman Scherer
2024-01-17  9:56 ` Mathieu Othacehe
2024-01-17 19:46   ` Roman Scherer
2024-01-17 19:48 ` Roman Scherer [this message]
2024-01-24 22:30   ` bug#68484: [PATCH v2] " Ludovic Courtès
2024-01-24 22:45     ` [bug#68484] " Roman Scherer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b02a6b5855a3c9281574ce96cb57bd383cb90593.1705520751.git.roman@burningswell.com \
    --to=roman@burningswell.com \
    --cc=68484@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.