all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jack Hill <jackhill@jackhill.us>
To: Dominik Delgado Steuter <d@delgado.nrw>
Cc: 63117@debbugs.gnu.org
Subject: [bug#63117] [PATCH] gnu: yt-dlp: Change input.
Date: Sat, 29 Apr 2023 00:36:01 -0400 (EDT)	[thread overview]
Message-ID: <alpine.DEB.2.21.2304290028040.331@marsh.hcoop.net> (raw)
In-Reply-To: <20230427143200.13000-1-d@delgado.nrw>

On Thu, 27 Apr 2023, Dominik Delgado Steuter via Guix-patches via wrote:

> yt-dlp complained when the "--add-metadata" flag was used.
> youtube-dl does not need ffmpeg as a propagated-input, though.

Dominik,

Thanks for working on improving our yt-dlp package. Can you explain a 
little more about why yt-dlp needs ffmpeg to be propagated? I haven't 
looked too closely, but I suspect yt-dlp just want to be able to call 
ffmpeg at runtime. If that's true, then I think it would be better to use 
substitute* in a phase so that yt-dlp can use the full path to ffmpeg, and 
not clutter folks' profiles.

If I'm correct, can you provide an updated patch that does that? I'm happy 
to provide more guidance if you need it.

If I'm wrong and ffmpeg needs to be propagated for some other reason, can 
you add a comment in the code explaining the need?

Best,
Jack




  reply	other threads:[~2023-04-29  4:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-27 14:32 [bug#63117] [PATCH] gnu: yt-dlp: Change input Dominik Delgado Steuter via Guix-patches via
2023-04-29  4:36 ` Jack Hill [this message]
2023-05-01 22:39   ` Dominik Delgado Steuter via Guix-patches via
2023-05-05 19:50 ` [bug#63117] [PATCH] gnu: yt-dlp: Fix substitution for ffmpeg path Dominik Delgado Steuter via Guix-patches via
2023-05-06  4:23   ` Liliana Marie Prikler
2023-05-20 13:49 ` Dominik Delgado Steuter via Guix-patches via
2023-05-25 10:42   ` bug#63117: [PATCH] gnu: yt-dlp: Change input Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.2304290028040.331@marsh.hcoop.net \
    --to=jackhill@jackhill.us \
    --cc=63117@debbugs.gnu.org \
    --cc=d@delgado.nrw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.