all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Tristan Cottam <tristan@cott.am>, 67200@debbugs.gnu.org
Cc: 宋文武 <iyzsong@envs.net>
Subject: [bug#67200] [PATCH] gnu: Add minetest-server.
Date: Wed, 15 Nov 2023 19:39:06 +0100	[thread overview]
Message-ID: <a8a3cbc37076ea61ff1eefbab281ded291dd23e4.camel@gmail.com> (raw)
In-Reply-To: <008d012987a89335df89e1b1c13a553b2fd7fe55.1700049181.git.tristan@cott.am>

Am Mittwoch, dem 15.11.2023 um 12:53 +0100 schrieb Tristan Cottam:
> * gnu/packages/minetest.scm (minetest-server): New variable.
> 
> Change-Id: I1125888b2944acc4063a19db4c602d33286a7e14
> ---
> 
> This package is a variant of minetest, with modified arguments and
> dropped
> inputs.
> 
> About the inputs, I'm having a hard time understanding why certain of
> them (i.e. pkg-config, coreutils, libxxf86vm, and ncurses) are
> specified for minetest in the first place; the docs make no mention
> of them, and the package builds fine without them.
pkg-config is nice to have for dependency resolution, though I don't
know whether the current version of minetest makes use of it. 
Coreutils were at one point required to patch rm; I hope minetest now
uses system calls for that.  The other two I don't know.

>  gnu/packages/minetest.scm | 36 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
> 
> diff --git a/gnu/packages/minetest.scm b/gnu/packages/minetest.scm
> index bf0df314a7..4d658f9e03 100644
> --- a/gnu/packages/minetest.scm
> +++ b/gnu/packages/minetest.scm
> @@ -44,6 +44,7 @@ (define-module (gnu packages minetest)
>    #:use-module (guix packages)
>    #:use-module (guix gexp)
>    #:use-module (guix git-download)
> +  #:use-module (guix utils)
>    #:use-module (guix build-system cmake)
>    #:use-module (guix build-system copy)
>    #:use-module (guix build-system minetest)
> @@ -154,6 +155,41 @@ (define-public minetest
>      (home-page "https://www.minetest.net/")
>      (license license:lgpl2.1+)))
>  
> +(define-public minetest-server
> +  (package
> +    (inherit minetest)
> +    (name "minetest-server")
> +    (arguments
> +     (substitute-keyword-arguments (package-arguments minetest)
> +       ((#:configure-flags configure-flags)
> +        #~(cons* "-DBUILD_CLIENT=FALSE"
> +                 "-DBUILD_SERVER=TRUE"
> +                 #$configure-flags))
> +       ((#:phases phases)
> +        #~(modify-phases #$phases
> +            (replace 'check
> +              (lambda* (#:key tests? #:allow-other-keys)
> +                (when tests?
> +                  (setenv "HOME" "/tmp")
> +                  (invoke "src/minetestserver" "--run-
> unittests"))))))))
> +    (inputs
> +     (modify-inputs (package-inputs minetest)
> +       (delete "libjpeg-turbo"
> +               "libpng"
> +               "libogg"
> +               "libvorbis"
> +               "libxxf86vm"
> +               "mesa"
> +               "openal")))
> +    (synopsis "Infinite-world block sandbox game (server)")
> +    (description
> +     "Minetest is a sandbox construction game.  Players can create
> and destroy
> +various types of blocks in a three-dimensional open world.  This
> allows
> +forming structures in every possible creation, on multiplayer
> servers or as a
> +single player.  Mods and texture packs allow players to personalize
> the game
> +in different ways.  This package provides @command{minetestserver}
> to run a
> +Minetest server.")))
> +
>  (define minetest-data
>    (package
>      (name "minetest-data")
> 
> base-commit: bd0f2173210416e86281c1de8789e7cdab66dd57
LGTM, assuming CI lights green.

Cheers




  reply	other threads:[~2023-11-15 18:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-15 11:53 [bug#67200] [PATCH] gnu: Add minetest-server Tristan Cottam via Guix-patches via
2023-11-15 18:39 ` Liliana Marie Prikler [this message]
2023-11-15 21:31   ` Tristan Cottam via Guix-patches via
2023-11-15 21:49     ` Liliana Marie Prikler
2023-11-22 20:43       ` Tristan Cottam via Guix-patches via
2023-11-23 11:15         ` Liliana Marie Prikler
2023-11-23 12:28           ` Tristan Cottam via Guix-patches via
2023-12-01 17:47             ` Tristan Cottam via Guix-patches via
2024-01-14 12:07 ` bug#67200: " Liliana Marie Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8a3cbc37076ea61ff1eefbab281ded291dd23e4.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=67200@debbugs.gnu.org \
    --cc=iyzsong@envs.net \
    --cc=tristan@cott.am \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.