all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "André Batista" <nandre@riseup.net>
To: "Clément Lassieur" <clement@lassieur.org>
Cc: 68503@debbugs.gnu.org
Subject: [bug#68503] [PATCH v3] gnu: torbrowser: Add support for language localisation.
Date: Sat, 20 Jan 2024 18:29:52 -0300	[thread overview]
Message-ID: <Zaw6xdQcOWjK3oz5@andel> (raw)
In-Reply-To: <5134d59e3a0e6749baaff2581f12cffa1fd0f363.1705615319.git.clement@lassieur.org>

[-- Attachment #1: Type: text/plain, Size: 2278 bytes --]

Hi Clément,

qui 18 jan 2024 às 23:46:49 (1705632409), clement@lassieur.org enviou:
> ...
>
> diff --git a/gnu/packages/tor.scm b/gnu/packages/tor.scm
> index b20e17e4cea8..fbd5f0a0af78 100644
> --- a/gnu/packages/tor.scm
> +++ b/gnu/packages/tor.scm
> ...
>
> @@ -503,6 +503,36 @@ (define %torbrowser-version "13.0.8")
>  ;; "src-firefox-tor-browser-".
>  (define %torbrowser-firefox-version "115.6.0esr-13.0-1-build2")
>  
> +;; Use the list in tor-browser-build/rbm.conf.
> +(define %torbrowser-locales
> +  '("ar" "ca" "cs" "da" "de" "el" "es-ES" "fa" "fi" "fr" "ga-IE" "he" "hu"
> +    "id" "is" "it" "ja" "ka" "ko" "lt" "mk" "ms" "my" "nb-NO" "nl" "pl"
> +    "pt-BR" "ro" "ru" "sq" "sv-SE" "th" "tr" "uk" "vi" "zh-CN" "zh-TW"))
> +
> +;; See tor-browser-build/projects/translation/config.
> +(define translation-base-browser
> +  (origin
> +    (method git-fetch)
> +    (uri (git-reference
> +          (url "https://gitlab.torproject.org/tpo/translation.git")
> +          (commit "5490489a8d356a44d792300b4dfddba792d10f2e")))
> +    (file-name "translation-base-browser")
> +    (sha256
> +     (base32
> +      "1knxary2zp2705xzzs76gpy37ri69yp32ajpmpxki3z5hp7mla7q"))))
> +
> +;; See tor-browser-build/projects/translation/config.
> +(define translation-tor-browser
> +  (origin
> +    (method git-fetch)
> +    (uri (git-reference
> +          (url "https://gitlab.torproject.org/tpo/translation.git")
> +          (commit "e92772b4a11ced855c27eafd299cf972bef5cd8f")))

The above commit is the one on the 'main' branch, but the current stable
browser follows 'maint-13.0' (which has now changed in preparation for
v13.0.9 release next Tuesday) and there is a tag for each release. The
release tag for version 13.0.8 (tbb-13.0.8-build1) contains a different
commit number (273592eca488ca3bf535d3789b1130fd1970f09a).

Other than that, everything seems to perfectly mirror upstream build
process. I've also built it, did some testing and it's working as
expected.

You are doing an awesome work, thanks!

PS: I'm sorry to have left you hanging on the lyrebird patch. I'll
review it and, if I find anything worth of attention, I'll ping back.
For now, I can only say that bridges are working just fine.

Cheers!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 667 bytes --]

  reply	other threads:[~2024-01-20 21:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-16 12:22 [bug#68503] [PATCH] gnu: torbrowser: Add support for language localisation Clément Lassieur
2024-01-16 12:40 ` Clément Lassieur
2024-01-16 13:31 ` [bug#68503] [PATCH v2] gnu: torbrowser: Add support or " Clément Lassieur
2024-01-18 22:46   ` [bug#68503] [PATCH v3] gnu: torbrowser: Add support for " Clément Lassieur
2024-01-20 21:29     ` André Batista [this message]
2024-01-21  0:15       ` bug#68503: " Clément Lassieur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zaw6xdQcOWjK3oz5@andel \
    --to=nandre@riseup.net \
    --cc=68503@debbugs.gnu.org \
    --cc=clement@lassieur.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.