all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: zimoun <zimon.toutoune@gmail.com>
Cc: Vagrant Cascadian <vagrant@debian.org>, guix-devel@gnu.org
Subject: Re: guix lint should support overrides
Date: Thu, 25 Aug 2022 14:31:08 +0300	[thread overview]
Message-ID: <YwddfFpUwv4fzPnu@3900XT> (raw)
In-Reply-To: <87h722xdvo.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1958 bytes --]

On Wed, Aug 24, 2022 at 10:08:27AM +0200, zimoun wrote:
> Hi Vagrant,
> 
> On Tue, 23 Aug 2022 at 15:22, Vagrant Cascadian <vagrant@debian.org> wrote:
> 
> > But, because there is no way to silence a particular inappropriate
> > suggestion from guix lint, it becomes noise, and each person evaluating
> > the results of the package in the future then needs to take time to
> > figure out if guix lint is wrong, or something should be changed.
> 
> Do you have some packages as example?  In order to be concrete about the
> false-positive and how to programatically fix them.
> 
> For instance, do you mean exclude on specific checker for one specific
> package?  Or teach one specific checker for one specific package in
> order to avoid an error specific to this package running this specific
> checker?

We have lint-hidden-cve. We also have a number of packages where there
is a string that is just too long but can't reasonably be cut shorter.

> 
> > The downside is this becomes one more thing to maintain... in exchange
> > for making the output having a higher degree of relevency in "guix lint"
> > output, so you can be more confident that someone hasn't already looked
> > at a given issue and decided it was best to just ignore it (not that
> > that will not ever happen anymore, but still).

The 'properties' field isn't mandatory, so if we just didn't add
something it wouldn't be a big deal.

> 
> The cost for a poor maintenance is low compared to the benefit, IMHO.
> 
> For instance, it is boring to run massive lint:
> 
>  1. because “guix lint” does not support the option --manifest
>  2. because “guix lint” reports some false-positive messages
> 
> 
> Cheers,
> simon
> 

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2022-08-25 11:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-23 22:22 guix lint should support overrides Vagrant Cascadian
2022-08-24  8:08 ` zimoun
2022-08-24 20:47   ` Maxime Devos
2022-09-02 13:40     ` Ludovic Courtès
2022-08-24 21:06   ` Vagrant Cascadian
2022-09-05 16:52     ` zimoun
2022-09-05 17:43       ` Vagrant Cascadian
2022-08-25 11:31   ` Efraim Flashner [this message]
2022-09-02 16:28 ` Felix Lechner via Development of GNU Guix and the GNU System distribution.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YwddfFpUwv4fzPnu@3900XT \
    --to=efraim@flashner.co.il \
    --cc=guix-devel@gnu.org \
    --cc=vagrant@debian.org \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.