all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: zimoun <zimon.toutoune@gmail.com>
Cc: 54088-done@debbugs.gnu.org
Subject: bug#54088: [PATCH 0/2] julia-build-system: Add missing julia-pkg-deps
Date: Thu, 24 Feb 2022 12:24:05 +0200	[thread overview]
Message-ID: <YhdcxUz0TFPzzKKt@3900XT> (raw)
In-Reply-To: <87sfs9hf3o.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1862 bytes --]

Great job! Patches pushed (with one change)

On Wed, Feb 23, 2022 at 02:44:43PM +0100, zimoun wrote:
> Hi Efraim,
> 
> On Mon, 21 Feb 2022 at 14:47, Efraim Flashner <efraim@flashner.co.il> wrote:
> 
> > It turns out we didn't expose julia-package-dependencies in the
> > julia-build-system, making the created Package.toml incomplete. This
> > corrects the omission and fixes the one package where it is manually
> > added.
> 
> All LGTM.  But I take this opportunity to uniform, as discussed:
> 
>         It's definitely the new pattern we're using now. I suppose it's
>         not really necessary here, but having more instances of it
>         throughout the codebase also makes it easier to search for
>         examples when others are looking to use or modify gexps.
> 
>         <https://issues.guix.gnu.org/issue/53656#4-lineno49>
> 
> The first patch of the series uses G-exps.  Note that it does not imply
> any rebuild.
> 
> The Julia build system is adapted for the new
> 'julia-package-dependencies' and so it requires the minor tweak to
> default with ''() instead of #f; otherwise it crashes for some packages.
> 
> Since we are at it, I fix a minor typo of how Julia uses --procs.  Other
> said, currently "guix build julia-media -c 0" works but not "guix build
> julia-media -c 1" which crashes.
> 
> Because the build system modifications imply a full Julia rebuild, let
> take the opportunity to remove the trailing #t.  It is done package per
> package because each modified package need a rebuild so it eases to
> follow, IMHO.  They can be squashed otherwise.
> 
> 
> Cheers,
> simon

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2022-02-24 10:26 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-21 12:47 [bug#54088] [PATCH 0/2] julia-build-system: Add missing julia-pkg-deps Efraim Flashner
2022-02-21 12:51 ` [bug#54088] [PATCH 1/2] build: julia: Add julia-package-dependencies as keyword Efraim Flashner
2022-02-21 12:51 ` [bug#54088] [PATCH 2/2] gnu: julia-media: Use julia-package-dependencies Efraim Flashner
2022-02-23 13:44 ` [bug#54088] [PATCH 0/2] julia-build-system: Add missing julia-pkg-deps zimoun
2022-02-24 10:24   ` Efraim Flashner [this message]
2022-02-24 10:39     ` zimoun
2022-02-23 13:47 ` [bug#54088] [PATCH v2 01/19] gnu: julia-xyz: Adjust style using G-expressions zimoun
2022-02-23 13:47   ` [bug#54088] [PATCH v2 02/19] build: julia: Add 'julia-package-dependencies' as keyword zimoun
2022-02-23 13:47   ` [bug#54088] [PATCH v2 03/19] gnu: julia-media: Use 'julia-package-dependencies' zimoun
2022-02-23 13:47   ` [bug#54088] [PATCH v2 04/19] build: julia-build-system: Fix corner-case for parallel tests zimoun
2022-02-23 13:47   ` [bug#54088] [PATCH v2 05/19] gnu: julia-codeczlib: Delete trailing #t zimoun
2022-02-24 10:23     ` Efraim Flashner
2022-02-24 10:39       ` zimoun
2022-02-23 13:47   ` [bug#54088] [PATCH v2 06/19] gnu: julia-dataframes: " zimoun
2022-02-23 13:47   ` [bug#54088] [PATCH v2 07/19] gnu: julia-datavalues: " zimoun
2022-02-23 13:47   ` [bug#54088] [PATCH v2 08/19] gnu: julia-finitediff: " zimoun
2022-02-23 13:47   ` [bug#54088] [PATCH v2 09/19] gnu: julia-fixedpointnumbers: " zimoun
2022-02-23 13:47   ` [bug#54088] [PATCH v2 10/19] gnu: julia-http: " zimoun
2022-02-23 13:47   ` [bug#54088] [PATCH v2 11/19] gnu: julia-imagemagick: " zimoun
2022-02-23 13:47   ` [bug#54088] [PATCH v2 12/19] gnu: julia-infinity: " zimoun
2022-02-23 13:47   ` [bug#54088] [PATCH v2 13/19] gnu: julia-matrixfactorizations: " zimoun
2022-02-23 13:47   ` [bug#54088] [PATCH v2 14/19] gnu: julia-mbedtls: " zimoun
2022-02-23 13:47   ` [bug#54088] [PATCH v2 15/19] gnu: julia-prettytables: " zimoun
2022-02-23 13:47   ` [bug#54088] [PATCH v2 16/19] gnu: julia-pycall: " zimoun
2022-02-23 13:47   ` [bug#54088] [PATCH v2 17/19] gnu: julia-quadmath: " zimoun
2022-02-23 13:47   ` [bug#54088] [PATCH v2 18/19] gnu: julia-stackviews: " zimoun
2022-02-23 13:47   ` [bug#54088] [PATCH v2 19/19] gnu: julia-uris: " zimoun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YhdcxUz0TFPzzKKt@3900XT \
    --to=efraim@flashner.co.il \
    --cc=54088-done@debbugs.gnu.org \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.