all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: 53418@debbugs.gnu.org
Cc: 53418-done@debbugs.gnu.org
Subject: [bug#53418] [PATCH] gnu: piper: Fix build.
Date: Fri, 21 Jan 2022 13:26:30 -0500	[thread overview]
Message-ID: <Yer61kl9N9ZTDRHH@jasmine.lan> (raw)
In-Reply-To: <FxvM2_cQc3tj3fX9k59Bo8WQL2VV3aUiRzP34Yt44c6d1VcvE2sENtUYDB48LMb1KonKiCADpVS5VwoHNua2pqEpcLS-dcRx9I5RT3yEz5Q=@protonmail.com>

On Fri, Jan 21, 2022 at 06:17:57PM +0000, John Kehayias via Guix-patches via wrote:
> Hello,
> 
> This is a followup to https://issues.guix.gnu.org/53372  fixing Piper (which uses libratbag). Python was added to the inputs to fix the build since Meson does not propagate Python (added to inputs rather than native-inputs as guix gc shows a reference to Python).
> 
> That allows Piper to build but it had a librsvg error on startup, like syncthing-gtk in https://issues.guix.gnu.org/52651  Fixed the same way here by removing librsvg from inputs since it is propagated by gtk+.
> 
> (Also simplified the input labels while I was at it, but my quick attempt at rewriting the phases with gexps didn't get far. Since I didn't find any similar examples in current packages, I left it as is for now.)
> 
> Thanks!
> John

> From 5ae7945017dc4d664bdc6ddbffaea6422db72402 Mon Sep 17 00:00:00 2001
> From: John Kehayias <john.kehayias@protonmail.com>
> Date: Fri, 21 Jan 2022 13:05:15 -0500
> Subject: [PATCH] gnu: piper: Fix build.
> 
> Since commit 6f36d0c89e3bf19bb7bb8f7f5b77de30c9af861b, Meson no longer
> propagates Python.  GTK+ propagates librsvg-bootstrap which causes a startup
> error due to two librsvg being GI_TYPELIB_PATH.
> 
> * gnu/packages/gnome.scm (piper)[inputs]: Add PYTHON.  Remove LIBRSVG.  Simplify.
> [native-inputs]: Simplify.
> [arguments]: Remove trailing #t from phases.

Thanks! Pushed as 0baf5efe01d613f82edca39b47ef2126803127a4




      reply	other threads:[~2022-01-21 18:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-21 18:17 [bug#53418] [PATCH] gnu: piper: Fix build John Kehayias via Guix-patches via
2022-01-21 18:26 ` Leo Famulari [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yer61kl9N9ZTDRHH@jasmine.lan \
    --to=leo@famulari.name \
    --cc=53418-done@debbugs.gnu.org \
    --cc=53418@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.