From: Efraim Flashner <efraim@flashner.co.il>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 路辉 <luhux76@gmail.com>, 53318@debbugs.gnu.org
Subject: [bug#53318] [PATCH] gnu: Add go-github-com-go-chi-chi-v5.
Date: Wed, 19 Jan 2022 13:04:11 +0200 [thread overview]
Message-ID: <YefwK7xmVt2qNQRl@3900XT> (raw)
In-Reply-To: <36129597cc215850f16001832244b76558e3f67c.camel@telenet.be>
[-- Attachment #1: Type: text/plain, Size: 1388 bytes --]
On Tue, Jan 18, 2022 at 06:51:29PM +0100, Maxime Devos wrote:
> Hi,
>
> Please keep debbugs in CC: or To: so other people know how the patch is
> progressing.
>
> 路辉 schreef op di 18-01-2022 om 15:26 [+0000]:
> > OK, new patch: [...]
>
> I did the following checks:
>
> 1. [x] it builds
> 2. [x] "guix lint" shows no problems
> 3. [x] there doesn't appear to be any malware in the source code
>
> While doing (3), I noticed that the test code has a certificate
> ‘certs.pem’ and ‘key.pem’, which will expire eventually, which isn't
> good for long-term reproducibility
> (cf. https://issues.guix.gnu.org/44559).
>
> So in the adjusted package definition, I deleted the affected test
> ‘middleware/middleware_test.go’, 'testdata/cert.pem' and
> 'testdata/key.pem', see attachement.
>
> I also capitalised 'http' to 'HTTP' in the description.
> The description is a bit short but I don't have much of an idea
> how to improve it.
>
> Aside from that, it LGTM.
FWIW when I imported this package I got the following description:
Package chi is a small, idiomatic and composable router for building HTTP services.
--
Efraim Flashner <efraim@flashner.co.il> רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-01-19 11:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 14:45 [bug#53318] [PATCH] gnu: Add go-github-com-go-chi-chi-v5 路辉
2022-01-17 19:13 ` Maxime Devos
[not found] ` <CAGNyvegjVYJcR7_MCdHyfSVzkJqhWTdrT7B4guk4Jh-kkGT8JQ@mail.gmail.com>
2022-01-18 17:51 ` Maxime Devos
2022-01-19 11:04 ` Efraim Flashner [this message]
2022-01-18 3:06 ` [bug#53318] [PATCH v2] " jgart via Guix-patches via
2022-01-28 9:53 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YefwK7xmVt2qNQRl@3900XT \
--to=efraim@flashner.co.il \
--cc=53318@debbugs.gnu.org \
--cc=luhux76@gmail.com \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.