all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Josselin Poiret <dev@jpoiret.xyz>
Cc: 52486@debbugs.gnu.org
Subject: [bug#52486] [PATCH v2 2/2] gnu: deluge: Remove reference of build-time librsvg
Date: Sun, 16 Jan 2022 12:58:41 -0500	[thread overview]
Message-ID: <YeRc0aIvXWsXY/Nf@jasmine.lan> (raw)
In-Reply-To: <20211214191713.18665-3-dev@jpoiret.xyz>

On Tue, Dec 14, 2021 at 08:17:13PM +0100, Josselin Poiret wrote:
> * gnu/packages/bittorrent.scm (deluge): Do it.

Thanks for working on this!

Can you send a followup patch adding a code comment that explains the
change? It's good practice to explain code that does strange things,
especially in packages. Otherwise later package maintainers may feel
free to remove it.




  reply	other threads:[~2022-01-16 17:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-14 17:21 [bug#52486] [PATCH] gnu: deluge: Move librsvg to native inputs Josselin Poiret via Guix-patches via
2021-12-14 17:56 ` Leo Famulari
2021-12-14 19:17   ` [bug#52486] [PATCH v2 0/2] Fix deluge propagating a librsvg incompatible with that of gtk+ Josselin Poiret via Guix-patches via
2021-12-14 19:17     ` [bug#52486] [PATCH v2 1/2] gnu: deluge: Move librsvg to native inputs Josselin Poiret via Guix-patches via
2021-12-14 19:17     ` [bug#52486] [PATCH v2 2/2] gnu: deluge: Remove reference of build-time librsvg Josselin Poiret via Guix-patches via
2022-01-16 17:58       ` Leo Famulari [this message]
2022-01-16 21:41         ` [bug#52486] [PATCH] gnu: deluge: Move librsvg to native inputs Brice Waegeneire
2022-01-16 10:52     ` bug#52486: " Brice Waegeneire
2022-01-16 10:52     ` [bug#52486] " Brice Waegeneire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YeRc0aIvXWsXY/Nf@jasmine.lan \
    --to=leo@famulari.name \
    --cc=52486@debbugs.gnu.org \
    --cc=dev@jpoiret.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.