all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: 51739@debbugs.gnu.org
Subject: [bug#51739] [PATCH 3/3] gnu: Add rdate.
Date: Wed, 10 Nov 2021 17:29:44 -0500	[thread overview]
Message-ID: <YYxH2BGl9QKXwweV@jasmine.lan> (raw)
In-Reply-To: <kp9AWdEEXaZbjd9epDygdzA9aOR9qbdm407QfhvojIvz_n95Gs20MqKtFug3IQNbdFF70TtUsibU1nEY5EgXVH7tTX_fTmaVgZ4tKyfN_dQ=@protonmail.com>

On Wed, Nov 10, 2021 at 03:08:17AM +0000, phodina via Guix-patches via wrote:
> * gnu/packages/time.scm (rdate): New variable.

Thanks for the patch!

> +(define-public rdate
> +  (let ((commit "91d84610e3695e90a884e2953908e95a856a9b74")
> +        (revision "1"))
> +    (package
> +      (name "rdate")
> +      (version commit)

As described in the manual section Version Numbers [0], we should use the
git-version procedure to create the package's version. As the most
recent Git tag before the specified commit is 1.4, it would be like
this:

(version (git-version "1.4" revision commit))

> +      (synopsis "Get date and time based on RFC 868")
> +      (description "@code{rdate} connects to an RFC 868 time server over a TCP/IP
> +network, printing the returned time and/or setting the system clock.")
> +      (home-page "https://www.aelius.com/njh/rdate/")
> +      (license license:gpl2))))

The license header of 'src/rdate.c' says "version 2 of the License, or
(at your option) any later version.", so the license is gpl2+.

Can you send a revised patch?

[0] https://guix.gnu.org/manual/en/html_node/Version-Numbers.html




  reply	other threads:[~2021-11-10 22:30 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-10  3:04 [bug#51739] [PATCH 1/3] gnu: Add realmd phodina via Guix-patches via
2021-11-10  3:07 ` [bug#51739] [PATCH 2/3] gnu: Use license: prefix phodina via Guix-patches via
2021-11-10 22:26   ` Leo Famulari
2021-11-10  3:08 ` [bug#51739] [PATCH 3/3] gnu: Add rdate phodina via Guix-patches via
2021-11-10 22:29   ` Leo Famulari [this message]
2021-11-10 22:33 ` [bug#51739] [PATCH 1/3] gnu: Add realmd Leo Famulari
2021-12-01 16:43   ` Ludovic Courtès
2021-12-01 16:42 ` Ludovic Courtès
2021-12-02 19:08   ` phodina via Guix-patches via
2021-12-02 19:13   ` phodina via Guix-patches via
2021-12-02 19:24     ` Leo Famulari
2021-12-02 21:50   ` phodina via Guix-patches via
2021-12-02 22:24     ` Leo Famulari
2021-12-03 14:17     ` phodina via Guix-patches via
2021-12-08 19:27       ` bug#51739: " Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YYxH2BGl9QKXwweV@jasmine.lan \
    --to=leo@famulari.name \
    --cc=51739@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.