all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Justin Veilleux <justun1011@gmail.com>
Cc: 49583@debbugs.gnu.org
Subject: bug#49583: [PATH] gnu: Add transmission-remote-gtk.
Date: Thu, 15 Jul 2021 16:56:27 -0400	[thread overview]
Message-ID: <YPCg+6xaZ7xeNPgD@jasmine.lan> (raw)
In-Reply-To: <CAJppLC8koSAh4kQGwPcGc-QbAqnjH+tmicVvUYVxgGw_CSu7yg@mail.gmail.com>

On Thu, Jul 15, 2021 at 02:31:08PM -0400, Justin Veilleux wrote:
> From 426aa9bd6b758628249df7c0925179ce39054f29 Mon Sep 17 00:00:00 2001
> From: terramorpha <terramorpha@cock.li>
> Date: Thu, 15 Jul 2021 14:27:35 -0400
> Subject: [PATCH] gnu: Add transmission-remote-gtk.
> 
> * gnu/packages/bittorrent.scm (transmission-remote-gtk): New variable.

Thanks! Overall looks good.

I ran `guix lint` on it and got these warnings which should be addressed:

/home/leo/work/guix/gnu/packages/bittorrent.scm:165:5: transmission-remote-gtk@1.4.1: 'gettext' should probably be a native input
/home/leo/work/guix/gnu/packages/bittorrent.scm:161:0: transmission-remote-gtk@1.4.1: parentheses feel lonely, move to the previous or next line
/home/leo/work/guix/gnu/packages/bittorrent.scm:170:14: transmission-remote-gtk@1.4.1: synopsis should start with an upper-case letter or digit
/home/leo/work/guix/gnu/packages/bittorrent.scm:170:14: transmission-remote-gtk@1.4.1: no article allowed at the beginning of the synopsis

> +    (arguments
> +     `(#:tests? #f ; the tests fail
> +                ))

We need more of an explanation for why the tests should be disabled. Did
you look into the failure and try to determine if it represents some
real problems?




  reply	other threads:[~2021-07-15 20:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-15 18:31 bug#49583: [PATH] gnu: Add transmission-remote-gtk Justin Veilleux
2021-07-15 20:56 ` Leo Famulari [this message]
2021-07-16 16:01 ` bug#49583: [PATCH v2] Justin Veilleux
2021-07-17  3:55   ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YPCg+6xaZ7xeNPgD@jasmine.lan \
    --to=leo@famulari.name \
    --cc=49583@debbugs.gnu.org \
    --cc=justun1011@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.