all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: Chris Marusich <cmmarusich@gmail.com>
Cc: 47698@debbugs.gnu.org
Subject: bug#47698: [powerpc64le-linux] "check" package fails to build
Date: Fri, 4 Jun 2021 12:11:43 +0300	[thread overview]
Message-ID: <YLnuTxJuDXM37KEs@3900XT> (raw)
In-Reply-To: <87eedit8tu.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1685 bytes --]

On Thu, Jun 03, 2021 at 11:58:21PM -0700, Chris Marusich wrote:
> Chris Marusich <cmmarusich@gmail.com> writes:
> 
> > [...] I've reported this issue upstream:
> > https://github.com/libcheck/check/issues/333
> 
> Branden Archer replied in the above issue.  In short, the unreleased
> upstream commit 4fbe702fa4f35bee8a90512f9f59d1441c4ae82e fixes this
> issue on PPC platforms.  Here's what the commit does:
> 
> https://github.com/libcheck/check/commit/4fbe702fa4f35bee8a90512f9f59d1441c4ae82e.patch
> 
>   Adjust test suite for 106-bit long double precision
> 
>   On PowerPC architectures (ppc, ppc64el, powerp) 'long double' has a
>   precision of 106-bit, compared to 80-bit precision on amd64.
> 
>   This leads to the test_ck_assert_(float|double|ldouble)_eq_tol succeed
>   rather than fail as expected, cause 0.003-0.002 will be actually
>   slightly bigger than 0.001 and not slightly smaller.
> 
>   Increase the change to the tolerance, so it will be on all architectures
>   smaller than the difference of ~0.001 and the unit tests will fail as
>   expected.
> 
> This commit was merged to the check repository's master branch after its
> latest release (0.15.2).  It will be included in the next check release,
> but until then, we will have to apply the fix as a patch to our check
> package.  I've attached a patch that does this.
> 
> -- 
> Chris

I'm trying it out now on powerpc-linux, where check was also failing.


-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2021-06-04  9:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-11  1:00 bug#47698: [powerpc64le-linux] "check" package fails to build Chris Marusich
2021-04-12 19:10 ` Chris Marusich
2021-04-13 11:12   ` Efraim Flashner
2021-05-14  7:45 ` Chris Marusich
2021-06-04  6:58   ` Chris Marusich
2021-06-04  9:11     ` Efraim Flashner [this message]
2021-06-04  9:36     ` Efraim Flashner
2021-06-08  8:22       ` Efraim Flashner
2021-06-18 18:09         ` Chris Marusich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YLnuTxJuDXM37KEs@3900XT \
    --to=efraim@flashner.co.il \
    --cc=47698@debbugs.gnu.org \
    --cc=cmmarusich@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.