From: Leo Famulari <leo@famulari.name>
To: 45601@debbugs.gnu.org
Subject: [bug#45601] [PATCH] gnu: Add wyhash.
Date: Sun, 3 Jan 2021 21:07:55 -0500 [thread overview]
Message-ID: <X/J4e6ZeWlTIystM@jasmine.lan> (raw)
In-Reply-To: <20210101211926.29943-1-rprior@protonmail.com>
On Fri, Jan 01, 2021 at 09:19:29PM +0000, Ryan Prior via Guix-patches via wrote:
> * gnu/packages/datastructures.scm (wyhash): New variable.
Thanks!
Pushed as 4a829b2d55bc9b0ad5a335c8228a7d2371fa1d9a with the following
changes...
I corrected the commit message (changing "datastructures.scm" to
"digest.scm"), tweaked the logic of the builder to be more idiomatic,
and removed the period at the end of the synopsis (`guix lint`
complained).
> + #:builder
> + (begin
> + (use-modules (guix build utils))
> + (let* ((out (string-append (assoc-ref %outputs "out")))
> + (src (string-append out "/include"))
> + (doc (string-append out "/share/doc/" ,name "-" ,version)))
> + (mkdir-p src)
> + (mkdir-p doc)
> + (chdir (assoc-ref %build-inputs "source"))
> + (install-file "wyhash.h" src)
> + (install-file "LICENSE" doc)
> + (install-file "README.md" doc))
> + #t)))
Regarding the builder:
1) install-file does mkdir-p [0], so that can be omitted.
2) I think it's more clear to use "include" rather than "src" when
binding the output's include directory
3) Using with-directory-excursion instead of chdir is more in tune with
a functional coding style [1], in my opinion
[0]
https://git.savannah.gnu.org/cgit/guix.git/tree/guix/build/utils.scm?h=version-1.2.0#n310
[1]
https://guix.gnu.org/manual/en/html_node/Programming-Paradigm.html
next prev parent reply other threads:[~2021-01-04 2:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-01 19:23 [bug#45601] [PATCH 0/6] vlang 0.2 update Ryan Prior via Guix-patches via
2021-01-01 19:27 ` [bug#45601] [PATCH 1/6] gnu: Add wyhash Ryan Prior via Guix-patches via
2021-01-01 19:27 ` [bug#45601] [PATCH 2/6] gnu: vlang: Update to 0.2 Ryan Prior via Guix-patches via
2021-01-01 19:27 ` [bug#45601] [PATCH 3/6] gnu: vlang: Use system tiny-bignum Ryan Prior via Guix-patches via
2021-01-01 19:27 ` [bug#45601] [PATCH 4/6] gnu: vlang: Use system cJSON Ryan Prior via Guix-patches via
2021-01-01 19:27 ` [bug#45601] [PATCH 5/6] gnu: vlang: Use system wyhash Ryan Prior via Guix-patches via
2021-01-01 19:27 ` [bug#45601] [PATCH 6/6] gnu: vlang: Fix v tools Ryan Prior via Guix-patches via
2021-01-01 20:46 ` [bug#45601] [PATCH 1/6] gnu: Add wyhash Leo Famulari
2021-01-01 21:19 ` [bug#45601] [PATCH] " Ryan Prior via Guix-patches via
2021-01-04 2:07 ` Leo Famulari [this message]
2021-01-03 0:09 ` [bug#45601] [PATCH] gnu: vlang: Update to 0.2 Ryan Prior via Guix-patches via
2021-01-04 1:46 ` [bug#45601] [PATCH 0/2] Another vlang dependency plucked out (re: bug#45601) Ryan Prior via Guix-patches via
2021-01-04 1:46 ` [bug#45601] [PATCH 1/2] gnu: Add picoev Ryan Prior via Guix-patches via
2021-01-04 1:46 ` [bug#45601] [PATCH 2/2] gnu: vlang: Use system picoenv Ryan Prior via Guix-patches via
2021-01-04 2:57 ` [bug#45601] [PATCH] gnu: Add wyhash Ryan Prior via Guix-patches via
2021-01-04 3:07 ` [bug#45601] [PATCH 0/1] Updated picoev patch based on feedback Ryan Prior via Guix-patches via
2021-01-04 3:07 ` [bug#45601] [PATCH 1/1] gnu: Add picoev Ryan Prior via Guix-patches via
2021-02-05 13:30 ` Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/J4e6ZeWlTIystM@jasmine.lan \
--to=leo@famulari.name \
--cc=45601@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.