all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: 宋文武 <iyzsong@outlook.com>
To: Zhu Zihao <all_but_last@163.com>
Cc: 44920@debbugs.gnu.org
Subject: [bug#44920] [PATCH]: Add fcitx5.
Date: Sun, 06 Dec 2020 16:30:22 +0800	[thread overview]
Message-ID: <TYAP286MB01858ABE93AFC07D1D5E05B9A3CF0@TYAP286MB0185.JPNP286.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <86eek499my.fsf@163.com> (Zhu Zihao's message of "Sat, 05 Dec 2020 12:09:25 +0800")

Hello, thanks for the patches!

Zhu Zihao <all_but_last@163.com> writes:
>>> This is a series of patches, add fcitx5 and its build dependecies.
>>> a qt5 and gtk2/3 plugin, chinese inputmethod addon and a material theme
>>>
>>> From cbe128e488078b3af8f7d1bdb4bf9dc9f12a2f0b Mon Sep 17 00:00:00 2001
>>> From: Zhu Zihao <all_but_last@163.com>
>>> Date: Sat, 28 Nov 2020 13:16:50 +0800
>>> Subject: [PATCH 1/9] gnu: Add xcb-imdkit.
>>>
>>> * gnu/packages/fcitx5.scm: New file.
>>> (xcb-imdkit): New variable.
>>
>> These packages should be put into gnu/packages/fcitx.scm.
>
> Why? It currently only used by fcitx5.

I’d like to put fcitx5 things into “fcitx.scm” too, as the author and
the github organization dosen’t changed for fcitx5, likewise we also
have both qt4 and qt5 in qt.scm and gtk2 and gtk3 in gtk.scm.


> [0001-gnu-Add-xcb-imdkit.patch]
This patch import guix modules that only needed later by ‘fcitx’, should
clean it up…

Otherwise look good to me!

Also I see fcitx5 got a new release recently (eg: xcb-imdkit -> 1.0.1,
fcitx5 -> 5.0.3), could you update this patches series for ‘fcitx.scm’
and the latest release?

Thank you!




  reply	other threads:[~2020-12-06 16:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-28  5:44 [bug#44920] [PATCH]: Add fcitx5 Zhu Zihao
2020-12-03  4:09 ` Peng Mei Yu
2020-12-05  4:09   ` Zhu Zihao
2020-12-06  8:30     ` 宋文武 [this message]
2020-12-06 15:38       ` [bug#44920] " Zhu Zihao
2020-12-07 10:55         ` 宋文武
2020-12-07 14:53           ` Zhu Zihao
2020-12-08 12:37             ` bug#44920: " 宋文武
2020-12-07 15:36           ` [bug#44920] " Zhu Zihao
2020-12-08 10:30           ` Zhu Zihao
2020-12-08 12:43             ` 宋文武

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TYAP286MB01858ABE93AFC07D1D5E05B9A3CF0@TYAP286MB0185.JPNP286.PROD.OUTLOOK.COM \
    --to=iyzsong@outlook.com \
    --cc=44920@debbugs.gnu.org \
    --cc=all_but_last@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.