all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: 宋文武 <iyzsong@outlook.com>
To: Kei Kebreau <kkebreau@posteo.net>
Cc: 45062@debbugs.gnu.org
Subject: [bug#45062] [PATCH 1/2] gnu: xfce4-session: Fix xfce4-panel plugin detection.
Date: Mon, 07 Dec 2020 19:21:51 +0800	[thread overview]
Message-ID: <TYAP286MB018505ABD00FEB55EB99B34AA3CE0@TYAP286MB0185.JPNP286.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20201206145552.0cfe74d9@posteo.net> (Kei Kebreau's message of "Sun, 6 Dec 2020 14:55:52 -0500")

[-- Attachment #1: Type: text/plain, Size: 579 bytes --]

Kei Kebreau <kkebreau@posteo.net> writes:

> Installing both 'xfce4-panel' and 'xfce4-whiskermenu-plugin' into the
> user profile does work!
Okay, but I guess that will be some problem too, since then
X_XFCE4_LIB_DIRS would contain both system and user paths...

> Is there a way to make clear to users and
> administrators that xfce4-panel and its plugins should both be
> installed at the user or system level to ensure proper function?  I
> don't think it's obvious since our Xfce desktop service implicitly
> installs the xfce4-panel.

Yes, how about document it like this:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-doc-Document-about-xfce4-panel-plugins.patch --]
[-- Type: text/x-patch, Size: 1193 bytes --]

From 75fdb19ea4f68d7e8af899ef4611d269d4821f29 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong@member.fsf.org>
Date: Mon, 7 Dec 2020 19:11:03 +0800
Subject: [PATCH] doc: Document about xfce4-panel plugins.

* doc/guix.texi (Desktop Services): Document that xfce4-panel plugin packages
should be added to the 'packages' field of OS.
---
 doc/guix.texi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/doc/guix.texi b/doc/guix.texi
index a21c4d614e..5eb5b47e14 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -18563,6 +18563,12 @@ This service adds the @code{xfce} package to the system profile, and
 extends polkit with the ability for @code{thunar} to manipulate the file
 system as root from within a user session, after the user has authenticated
 with the administrator's password.
+
+Note that @code{xfce4-panel} and its plugin packages should in the same
+profile to ensure compatibility, when use this @code{xfce} service, you
+should add extra plugins (xfce4-whiskermenu-plugin,
+xfce4-weather-plugin, etc.) to the @code{packages} field of your
+@code{operating-system}.
 @end defvr
 
 @deftp {Data Type} xfce-desktop-configuration
-- 
2.29.2


[-- Attachment #3: Type: text/plain, Size: 85 bytes --]



BTW, your second patch for xfce4-whiskermenu-plugin LGTM, please push.

Thank you!

  reply	other threads:[~2020-12-07 11:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-06  5:02 [bug#45062] [PATCH 1/2] gnu: xfce4-session: Fix xfce4-panel plugin detection Kei Kebreau
2020-12-06  5:04 ` [bug#45062] [PATCH 2/2] gnu: xfce4-whiskermenu-plugin: Fix installed shell script Kei Kebreau
2020-12-06  6:50 ` [bug#45062] [PATCH 1/2] gnu: xfce4-session: Fix xfce4-panel plugin detection 宋文武
2020-12-06 19:55   ` Kei Kebreau
2020-12-07 11:21     ` 宋文武 [this message]
2020-12-07 21:17       ` bug#45062: " Kei Kebreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TYAP286MB018505ABD00FEB55EB99B34AA3CE0@TYAP286MB0185.JPNP286.PROD.OUTLOOK.COM \
    --to=iyzsong@outlook.com \
    --cc=45062@debbugs.gnu.org \
    --cc=kkebreau@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.