From: 宋文武 <iyzsong@outlook.com>
To: phodina <phodina@protonmail.com>
Cc: 49576@debbugs.gnu.org
Subject: [bug#49576] [PATCH] Add sterm
Date: Fri, 16 Jul 2021 21:03:15 +0800 [thread overview]
Message-ID: <OSZP286MB06643687F4E7D1BAFEFB92C8A3119@OSZP286MB0664.JPNP286.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <YvWqyYiYM7rF9eDfkGzFdqo-1zxweVs9dcnpVZKa7YzSHVNUkY5yohO6JIIKEUZPuKyU9fmxPs7034smQDp-hf5fcjDXRfxYuih7sKmTRWk=@protonmail.com> (phodina@protonmail.com's message of "Thu, 15 Jul 2021 16:17:13 +0000")
Hello!
phodina <phodina@protonmail.com> writes:
> ---
> index 4429a2b75a..a6f866cbea 100644
> --- a/gnu/packages/engineering.scm
> +++ b/gnu/packages/engineering.scm
> @@ -24,6 +24,7 @@
> ;;; Copyright © 2021 qblade <qblade@protonmail.com>
> ;;; Copyright © 2021 Gerd Heber <gerd.heber@gmail.com>
> ;;; Copyright © 2021 Guillaume Le Vaillant <glv@posteo.net>
> +;;; Copyright © 2021 Petr Hodina <phodina@protonmail.com>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -1297,6 +1298,35 @@ replacement for the OpenDWG libraries.")
> (description "@code{minicom} is a serial terminal emulator.")
> (license license:gpl2+)))
>
> +(define-public sterm
> +(package
> + (name "sterm")
> + (version "20200306")
> + (source (origin
> + (method git-fetch)
> + (uri
> + (git-reference
> + (url "https://github.com/wentasah/sterm")
> + (commit version)))
The indention seems wrong here, we usually use:
--8<---------------cut here---------------start------------->8---
(source (origin
(method git-fetch)
(uri (git-reference
(url "...")
(commit ...)))
(file-name (git-file-name name version))
(sha256
(base32
"..."))))
--8<---------------cut here---------------end--------------->8---
Also a 'file-name' field is needed to get a better store directory name
for the checkout.
> + (sha256
> + (base32
> + "031pd8yz2bfzqbari6za1c3xcqmw94ap4vbrjzb3v6izjcrca58c"))))
> + (build-system gnu-build-system)
> + (arguments
> + '(#:tests? #f
When disable tests, we should add a comment, a simple "no tests" will
do.
> + #:make-flags (list "PREFIX=$out" "CC=gcc")
I think "PREFIX=$out" is no effect here, also instead of 'gcc' you can
use 'cc-for-target' for cross-compile support, examples can be found in
suckless.scm:
--8<---------------cut here---------------start------------->8---
#:make-flags
(list (string-append "CC=" ,(cc-for-target))
(string-append "PREFIX=" %output))
--8<---------------cut here---------------end--------------->8---
> + #:phases (modify-phases %standard-phases
> + (delete 'configure)
> + (replace 'install
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let ((bin (string-append (assoc-ref outputs "out") "/bin")))
> + (install-file "sterm" bin)
> + #t))))))
Doesn't the builtin Makefile works? It also install a man page and
shell completion files.
> + (synopsis "Simple serial terminal")
> + (description "This is a minimalist terminal program like minicom or cu. The only thing it does is creating a bidirectional connection between stdin/stdout and a terminal device (e.g. serial line). It can also set serial line baudrate, manipulate DTR/RTS modem lines, send break and throttle transmission speed.")
Please keep lines below 80 characters, and use two spaces between
the two sentences.
> + (home-page "https://github.com/wentasah/sterm")
> + (license #f)))
According to the files, the license is GPLv3+.
Could you send an update patch? Thank you!
next prev parent reply other threads:[~2021-07-16 13:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 16:17 [bug#49576] [PATCH] Add sterm phodina via Guix-patches via
2021-07-16 13:03 ` 宋文武 [this message]
2021-07-17 10:50 ` phodina via Guix-patches via
2021-07-17 11:41 ` Tobias Geerinckx-Rice via Guix-patches via
2021-07-17 12:08 ` phodina via Guix-patches via
2021-07-18 9:42 ` bug#49576: " 宋文武
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OSZP286MB06643687F4E7D1BAFEFB92C8A3119@OSZP286MB0664.JPNP286.PROD.OUTLOOK.COM \
--to=iyzsong@outlook.com \
--cc=49576@debbugs.gnu.org \
--cc=phodina@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.