all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: 宋文武 <iyzsong@outlook.com>
To: Leo Famulari <leo@famulari.name>
Cc: 宋文武 <iyzsong@member.fsf.org>, 46587-done@debbugs.gnu.org
Subject: bug#46587: [PATCH] gnu: Add libretro-lowresnx.
Date: Sat, 20 Feb 2021 19:54:35 +0800	[thread overview]
Message-ID: <OS3P286MB0660FE0766527476BD87355DA3839@OS3P286MB0660.JPNP286.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <YC63dIkhUSWJtO8X@jasmine.lan> (Leo Famulari's message of "Thu, 18 Feb 2021 13:52:36 -0500")

Leo Famulari <leo@famulari.name> writes:

> On Wed, Feb 17, 2021 at 06:47:56PM +0800, iyzsong@outlook.com wrote:
>> From: 宋文武 <iyzsong@member.fsf.org>
>> 
>> * gnu/packages/emulators.scm (libretro-lowresnx): New variable.
>
> Thanks for the patch!
>
>> +           (replace 'build
>> +             (lambda _
>> +               (invoke "make" "-C" "platform/LibRetro"
>> +                       (string-append "CC=" ,(cc-for-target)))))
>
> I think it's more idiomatic for Guix to use #:make-flags, maybe like
> this (untested!):
>

It works, pushed, thank you!




      reply	other threads:[~2021-02-20 11:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-17 10:47 [bug#46587] [PATCH] gnu: Add libretro-lowresnx iyzsong
2021-02-18 18:52 ` Leo Famulari
2021-02-20 11:54   ` 宋文武 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OS3P286MB0660FE0766527476BD87355DA3839@OS3P286MB0660.JPNP286.PROD.OUTLOOK.COM \
    --to=iyzsong@outlook.com \
    --cc=46587-done@debbugs.gnu.org \
    --cc=iyzsong@member.fsf.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.