From: Julien Lepiller <julien@lepiller.eu>
To: 36599@debbugs.gnu.org, goodoldpaul@autistici.org, efraim@flashner.co.il
Subject: [bug#36599] [PATCH] gnu: Add node-semver. (Updated)
Date: Wed, 15 Apr 2020 13:09:41 -0400 [thread overview]
Message-ID: <E6B5A186-3A4A-43A4-A68E-0A9E174C823A@lepiller.eu> (raw)
In-Reply-To: <c7c5b4ec926007e9611d74a7cca62d48@autistici.org>
Le 15 avril 2020 11:36:06 GMT-04:00, goodoldpaul@autistici.org a écrit :
>Hi Efraim,
>
>> Overall it looks good to me. I also checked npm¹ and it agrees that
>> there are no dependencies for this package. Do you happen to know why
>> there's a test directory installed? I don't know if it's supposed to
>be
>> there but it seems strange to me
>
>I didn't notice and I agree that tests shouldn't be installed but IIUC
>it's a limitation of the node-build-system that copies recursively the
>contents of the node_modules directory. I checked and it seems that
>other packages using the node-build-system have the same problem (i.e.
>node-color-name install test.js, node-far installs a test directory).
>One way to fix this could be adding an extra phase (either to each
>package or in the node-build-system with a special field indicating a
>list of tests directories) where we delete the test directory from
>node_modules preventing the copy.
>
>On my system I get
>
>orang3@frastanato ~/code/guix [env]$ du -sh
>/gnu/store/5kkb1nya9ws12b2qxsn0r7904nx6v5b5-node-semver-7.2.1
>732K /gnu/store/5kkb1nya9ws12b2qxsn0r7904nx6v5b5-node-semver-7.2.1
>
>orang3@frastanato ~/code/guix [env]$ du -sh
>/gnu/store/5kkb1nya9ws12b2qxsn0r7904nx6v5b5-node-semver-7.2.1/lib/node_modules/semver/test/
>264K
>/gnu/store/5kkb1nya9ws12b2qxsn0r7904nx6v5b5-node-semver-7.2.1/lib/node_modules/semver/test/
>
>which is not much but amounts nearly to 1/3 of the total disk usage of
>semver. If you believe that another phase deleting the tests would be
>better I attached an attempt.
>
>Giacomo
Does npm install the test.js files when run by ittself (in which case we replicate its behavior), or does it have a mechanism to know what files to install? If so we thould replicate that mecanism.
next prev parent reply other threads:[~2020-04-15 17:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 12:12 [bug#36599] [PATCH] gnu: Add node-semver Giacomo Leidi
2019-09-02 12:49 ` Ludovic Courtès
2019-09-02 14:50 ` Julien Lepiller
2019-09-02 17:13 ` goodoldpaul
2020-04-07 23:06 ` [bug#36599] [PATCH] gnu: Add node-semver. (Updated) goodoldpaul
2020-04-09 20:01 ` Efraim Flashner
2020-04-15 15:36 ` goodoldpaul
2020-04-15 17:09 ` Julien Lepiller [this message]
2020-04-18 18:39 ` bug#36599: " Efraim Flashner
2020-04-17 14:54 ` [bug#36599] " goodoldpaul
2020-04-17 15:03 ` Efraim Flashner
2020-04-17 16:09 ` Julien Lepiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E6B5A186-3A4A-43A4-A68E-0A9E174C823A@lepiller.eu \
--to=julien@lepiller.eu \
--cc=36599@debbugs.gnu.org \
--cc=efraim@flashner.co.il \
--cc=goodoldpaul@autistici.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.