From: Jaft <jaft.r@outlook.com>
To: "52238@debbugs.gnu.org" <52238@debbugs.gnu.org>,
Liliana Marie Prikler <liliana.prikler@gmail.com>
Subject: [bug#52238] [PATCH] gnu: Add MEGA SDK
Date: Sat, 18 Dec 2021 05:14:48 +0000 (UTC) [thread overview]
Message-ID: <DM6PR19MB24605B6720DCE49BDE58192D99799@DM6PR19MB2460.namprd19.prod.outlook.com> (raw)
In-Reply-To: <b1afb49e9dfdf4ef6e61175b35a2d3c7f8168fce.camel@gmail.com>
> > + ;; XXX: Disabling tests because they depend on libgtest.la from
> > googletest,
> > + ;; which is not installed for unclear reasons.
> > + (arguments `(#:tests? #f))
> Unclear reasons including googletest not being present in the inputs?
> You probably want to swap out the .la dependency for a .so dependency.
Hmm; I thought it was for the same reasons that tests had been disabled for megacmd but, taking another look at it, it seems I'm misremembering from the last time I worked on this.
It says it's failing because the MEGA_EMAIL and MEGA_PWD environment variables aren't set; from what I can tell, it uses those to test whether it can interact with a MEGA account appropriately. As that'd require requests to the internet, I'd expect the tests to fail in the end, still; is that a reasonable reason to disable them or should I try some other course of action?
> > (define-public megacmd
> > (package
> > (name "megacmd")
> > @@ -222,8 +262,7 @@ (define-public megacmd
> > (method git-fetch)
> > (uri (git-reference
> > (url "https://github.com/meganz/MEGAcmd")
> > - (commit (string-append version "_Linux"))
> > - (recursive? #t)))
> > + (commit (string-append version "_Linux"))))
> > (sha256
> > (base32
> > "004j8m3xs6slx03g2g6wzr97myl2v3zc09wxnfar5c62a625pd53"))
> > @@ -242,6 +281,7 @@ (define-public megacmd
> > ("curl" ,curl)
> > ("freeimage" ,freeimage)
> > ("gtest" ,googletest)
> > + ("mega-sdk" ,mega-sdk)
> > ("openssl" ,openssl)
> > ("pcre" ,pcre)
> > ("readline" ,readline)
> Pardon me if I was unclear, but this would be done in a separate
> commit. But thanks anyway for confirming that it'd be easily
> swappable.
Gotcha; because I'm unsure, how should I do that? Should I just attach two separate patches? Or should I open a separate ticket for the megacmd update (with its own separate patch, of course)?
next prev parent reply other threads:[~2021-12-18 5:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1136809883.7440498.1638426746315.ref@mail.yahoo.com>
2021-12-02 6:32 ` [bug#52238] [PATCH] gnu: Add MEGA SDK Jaft
2021-12-06 19:52 ` Liliana Marie Prikler
2021-12-17 22:30 ` Jaft
2021-12-17 23:22 ` Liliana Marie Prikler
2021-12-18 5:14 ` Jaft [this message]
2021-12-18 7:47 ` Liliana Marie Prikler
2021-12-20 1:58 ` Jaft
2021-12-20 20:08 ` Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR19MB24605B6720DCE49BDE58192D99799@DM6PR19MB2460.namprd19.prod.outlook.com \
--to=jaft.r@outlook.com \
--cc=52238@debbugs.gnu.org \
--cc=liliana.prikler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.