all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Wilke Schwiedop via Guix-patches via <guix-patches@gnu.org>
To: "66887@debbugs.gnu.org" <66887@debbugs.gnu.org>
Subject: [bug#66887] Subject: [PATCH 2/3] gnu: podman: Use catatonit
Date: Wed, 1 Nov 2023 18:47:02 +0000	[thread overview]
Message-ID: <DB9P190MB1985F6B5C65B67E6ACA7DE939EA7A@DB9P190MB1985.EURP190.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <DB9P190MB1985EACDCB1AD8D10E7807F19EA7A@DB9P190MB1985.EURP190.PROD.OUTLOOK.COM>

defaultHelperBinariesDir is a string array of paths searched by the
FindHelperBinary function. This patch inserts new entries at the
beginning of array instead of modifying individual elements. This will
make it easier to include additional helper binaries, e.g. aardvark,
netavark and pasta.
---
 gnu/packages/containers.scm | 19 ++++++++++++++-----
 1 file changed, 14 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/containers.scm b/gnu/packages/containers.scm
index e26b5acf21..c00394af2b 100644
--- a/gnu/packages/containers.scm
+++ b/gnu/packages/containers.scm
@@ -381,22 +381,31 @@ (define-public podman
                 (("CATATONIT_PATH=\"[^\"]+\"")
                  (string-append "CATATONIT_PATH=" (which "true"))))
               (substitute* "vendor/github.com/containers/common/pkg/config/config_linux.go"
-                (("/usr/local/libexec/podman")
-                 (string-append #$output "/libexec/podman"))
-                (("/usr/local/lib/podman")
-                 (string-append #$output "/bin")))
+                (("var defaultHelperBinariesDir = ..string." all)
+                 (string-append
+                  all
+                  (string-join
+                   (map (lambda (s) (string-append "\n\"" s "\","))
+                        (list
+                         (string-append #$output "/libexec/podman")
+                         (string-append #$output "/bin")
+                         (string-append #$(this-package-input "catatonit") "/bin")))))))
               (substitute* "vendor/github.com/containers/common/pkg/config/default.go"
                 (("/usr/libexec/podman/conmon") (which "conmon"))
                 (("/usr/local/libexec/cni")
                  (string-append #$(this-package-input "cni-plugins")
                                 "/bin"))
-                (("/usr/bin/crun") (which "crun")))))
+                (("/usr/bin/crun") (which "crun"))
+                (("/usr/libexec/podman/catatonit") (which "catatonit")))
+              (substitute* "pkg/rootless/rootless_linux.c"
+                (("/usr/bin/catatonit") (which "catatonit")))))
           (add-after 'install 'install-completions
             (lambda _
               (invoke "make" "install.completions"
                       (string-append "PREFIX=" #$output)))))))
     (inputs
      (list btrfs-progs
+           catatonit
            cni-plugins
            conmon
            crun
-- 
2.41.0





  parent reply	other threads:[~2023-11-01 20:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-01 18:23 [bug#66887] Subject: [PATCH 0/3] catatonit for podman Wilke Schwiedop via Guix-patches via
2023-11-01 18:45 ` [bug#66887] Subject: [PATCH 1/3] gnu: Add catatonit Wilke Schwiedop via Guix-patches via
2023-11-01 18:47 ` Wilke Schwiedop via Guix-patches via [this message]
2023-11-01 18:47 ` [bug#66887] Subject: [PATCH 3/3] remove outdated comment Wilke Schwiedop via Guix-patches via
2023-11-08 17:22 ` [bug#66887] [PATCH v2 0/3] resending catatonit patches for QA Jack Hill
2023-11-08 17:24   ` [bug#66887] [PATCH v2 1/3] gnu: Add catatonit Jack Hill
2023-11-08 17:24   ` [bug#66887] [PATCH v2 2/3] gnu: podman: Use catatonit Jack Hill
2023-11-08 17:24   ` [bug#66887] [PATCH v2 3/3] remove outdated comment Jack Hill
2023-11-19 11:45   ` [bug#66887] [PATCH v2 0/3] resending catatonit patches for QA Wilke Schwiedop via Guix-patches via
2024-04-01 15:23 ` [bug#66887] Superceded by #70112 Wilke Schwiedop via Guix-patches via
2024-05-22 14:01   ` bug#66887: " Simon Tournier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB9P190MB1985F6B5C65B67E6ACA7DE939EA7A@DB9P190MB1985.EURP190.PROD.OUTLOOK.COM \
    --to=guix-patches@gnu.org \
    --cc=66887@debbugs.gnu.org \
    --cc=wilke.schwiedop@agfa.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.