From: Robert Vollmert <rob@vllmrt.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 35935@debbugs.gnu.org
Subject: [bug#35935] [PATCH] guix: import: simplify recursive import
Date: Sun, 2 Jun 2019 22:23:56 +0200 [thread overview]
Message-ID: <CBFF786D-3925-46D1-95AF-D676A7F0D8F2@vllmrt.net> (raw)
In-Reply-To: <87a7ez933m.fsf@gnu.org>
> On 2. Jun 2019, at 21:52, Ludovic Courtès <ludo@gnu.org> wrote:
> Robert Vollmert <rob@vllmrt.net> skribis:
>> * guix/import/utils.scm: Simplify recursive-import.
> ^
> Minor issue: please make sure to mention the modified entities here
> (procedures, variables, etc.); see
> <https://www.gnu.org/prep/standards/html_node/Change-Logs.html>.
Fixed, thanks for the heads up.
> I think Oleg worked on this part before; Oleg, could you comment
> and/or apply?
>
> ‘tests/import-utils.scm’ doesn’t seem to be testing this procedure,
> perhaps that’s something we should fix eventually.
Agreed. It does seem to be covered somewhat by tests/gem.scm.
I also tested it a bit by hand, with some haskell packages.
next prev parent reply other threads:[~2019-06-02 20:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-27 20:07 [bug#35935] [PATCH] guix: import: simplify recursive import Robert Vollmert
2019-06-02 19:52 ` Ludovic Courtès
2019-06-02 20:23 ` Robert Vollmert [this message]
2019-06-03 19:56 ` Oleg Pykhalov
2019-06-03 19:59 ` Robert Vollmert
2019-06-03 20:31 ` bug#35935: " Oleg Pykhalov
2019-06-02 20:19 ` [bug#35935] [PATCH] guix: import: Simplify " Robert Vollmert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CBFF786D-3925-46D1-95AF-D676A7F0D8F2@vllmrt.net \
--to=rob@vllmrt.net \
--cc=35935@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.