all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tatiana Sholokhova <tanja201396@gmail.com>
To: "Clément Lassieur" <clement@lassieur.org>
Cc: guix-devel <guix-devel@gnu.org>, 30728@debbugs.gnu.org
Subject: Re: bug#30728: Modification for guix installation script.
Date: Mon, 26 Mar 2018 19:09:38 +0300	[thread overview]
Message-ID: <CAMSS15DgqNa3j7OA1=brmomBnqG40xi6CK1G_pXgAZACozteaA@mail.gmail.com> (raw)
In-Reply-To: <87bmfb9eml.fsf@lassieur.org>


[-- Attachment #1.1: Type: text/plain, Size: 1123 bytes --]

Hello!

Could you please make that change on top of the current version of the
> Guix sources as a git commit?  Then you can run “git format-patch -1” to
> format it as a patch in a format that we can apply.  You can send the
> resulting patch file as an attachment to a reply to this email.
> This also fixes bug #30728, so please add this line to the commit
> message:
> --
> Ricardo


I have attached the patch file to this email. This patch fixes the
installation process but it place guix within root's directory.

I personally prefer that the Guix daemon points to my home directory
> because I don't want to update root's profile.  Some other people might
> prefer that it points to ~root because they might later delete their
> profile and want Guix to keep working.


> Do we have to take a decision here?  Can't we just let the user decide
> by letting them customize their environment variables?  I think it is
> the point of environment variables: giving freedom to users.


We can further work on the script's flexibility using the environment
variable solution.

--
Tatiana

[-- Attachment #1.2: Type: text/html, Size: 12878 bytes --]

[-- Attachment #2: 0001-Fixes-https-debbugs.gnu.org-30728.patch --]
[-- Type: text/x-patch, Size: 904 bytes --]

From f286b6e9c60cba54f3da68428fc034d272ba5ffc Mon Sep 17 00:00:00 2001
From: tsholokhova <tanja201396@gmail.com>
Date: Mon, 26 Mar 2018 18:59:40 +0300
Subject: [PATCH] Fixes <https://debbugs.gnu.org/30728>

---
 etc/guix-install.sh | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 933492a33..b4a9cdf94 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -263,10 +263,9 @@ sys_create_store()
     fi
 
     _msg "${INF}Linking the root user's profile"
-    ln -sf /var/guix/profiles/per-user/root/guix-profile \
-       ~root/.guix-profile
+    ln -sf /var/guix/profiles/per-user/root/guix-profile /root/.guix-profile
 
-    GUIX_PROFILE="${HOME}/.guix-profile"
+    GUIX_PROFILE="/root/.guix-profile"
     source "${GUIX_PROFILE}/etc/profile"
     _msg "${PAS}activated root profile at /root/.guix-profile"
 }
-- 
2.14.1


  reply	other threads:[~2018-03-26 16:09 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-24  9:04 Modification for guix installation script Tatiana Sholokhova
2018-03-24 16:46 ` Vincent Legoll
2018-03-24 17:00   ` Tatiana Sholokhova
2018-03-24 17:05     ` Vincent Legoll
2018-03-24 21:26       ` Tatiana Sholokhova
2018-03-25 15:26 ` bug#30728: " Ricardo Wurmus
2018-03-25 18:57   ` Mark H Weaver
2018-03-25 18:57   ` Mark H Weaver
2018-03-26  8:27 ` Clément Lassieur
2018-03-26  9:11   ` bug#30728: " Ricardo Wurmus
2018-03-26 12:59     ` Clément Lassieur
2018-03-26 12:59     ` Clément Lassieur
2018-03-26 16:09       ` Tatiana Sholokhova [this message]
2018-03-29  8:24         ` Clément Lassieur
2018-03-26 16:09       ` Tatiana Sholokhova
2018-03-27 11:53     ` Gábor Boskovits
2018-03-29  8:11       ` Clément Lassieur
2018-03-29  8:11       ` bug#30728: " Clément Lassieur
2018-03-27 11:53     ` Gábor Boskovits
2018-03-26  8:27 ` Clément Lassieur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMSS15DgqNa3j7OA1=brmomBnqG40xi6CK1G_pXgAZACozteaA@mail.gmail.com' \
    --to=tanja201396@gmail.com \
    --cc=30728@debbugs.gnu.org \
    --cc=clement@lassieur.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.