Re: [PATCH 06/31] gnu: kwindowsystem: Update to 5.24.0.

[David Craven <david@craven.ch>]

[-- Attachment #1: Type: text/plain, Size: 3277 bytes --]

So all test failures except two are resolved. I attached the wip
patches and pasted the logs below. I think this is getting to a
mergeable state =)

********* Start testing of KColumnResizerTest *********
Config: Using QtTest library 5.6.1, Qt 5.6.1
(x86_64-little_endian-lp64 shared (dynamic) release build; by GCC
4.9.3)
PASS   : KColumnResizerTest::initTestCase()
process 285: D-Bus library appears to be incorrectly set up; failed to
read machine uuid: Failed to open "/etc/machine-id": No such file or
directory
See the manual page for dbus-uuidgen to correct this issue.
QWARN  : KColumnResizerTest::test(forms) Unsupported screen format:
depth: 8, red_mask: 0, blue_mask: 0
QWARN  : KColumnResizerTest::test(forms) Unsupported screen format:
depth: 8, red_mask: 0, blue_mask: 0
libGL: OpenDriver: trying
/gnu/store/p9dwvvf9i16z6v9yawvz3z7yfy54xb5r-mesa-11.0.9/lib/dri/tls/swrast_dri.so
libGL: OpenDriver: trying
/gnu/store/p9dwvvf9i16z6v9yawvz3z7yfy54xb5r-mesa-11.0.9/lib/dri/swrast_dri.so
libGL: Can't open configuration file /etc/drirc: No such file or directory.
libGL: Can't open configuration file /home/dvc/.drirc: No such file or
directory.
libGL: Can't open configuration file /etc/drirc: No such file or directory.
libGL: Can't open configuration file /home/dvc/.drirc: No such file or
directory.
libGL error: No matching fbConfigs or visuals found
libGL error: failed to load driver: swrast
QWARN  : KColumnResizerTest::test(forms) Could not initialize OpenGL
for RasterGLSurface, reverting to RasterSurface.
QWARN  : KColumnResizerTest::test(forms) Unsupported screen format:
depth: 8, red_mask: 0, blue_mask: 0
QWARN  : KColumnResizerTest::test(forms) QPainter::begin: Paint device
returned engine == 0, type: 3
QWARN  : KColumnResizerTest::test(forms) QPainter::setCompositionMode:
Painter not active
QWARN  : KColumnResizerTest::test(forms) QWidget::paintEngine: Should
no longer be called
QWARN  : KColumnResizerTest::test(forms) QPainter::begin: Paint device
returned engine == 0, type: 1
QWARN  : KColumnResizerTest::test(forms) QPainter::save: Painter not active

========= Received signal, dumping stack ==============
========= End of stack trace ==============
QFATAL : KColumnResizerTest::test(forms) Received signal 11
         Function time: 30ms Total time: 30ms
FAIL!  : KColumnResizerTest::test(forms) Received a fatal error.
   Loc: [Unknown file(0)]
Totals: 1 passed, 1 failed, 0 skipped, 0 blacklisted
********* Finished testing of KColumnResizerTest *********

********* Start testing of KProcessTest *********
Config: Using QtTest library 5.6.1, Qt 5.6.1
(x86_64-little_endian-lp64 shared (dynamic) release build; by GCC
4.9.3)
PASS   : KProcessTest::initTestCase()
FAIL!  : KProcessTest::test_channels() Compared values are not the same
   Actual   (a): "mode: separate\nprogram output:\nreceived
stdout:\nreceived stderr:\n"
   Expected (e): "mode: separate\nprogram output:\nreceived
stdout:\nfoo - stdout\nreceived stderr:\nbar - stderr\n"
   Loc: [/tmp/guix-build-kcoreaddons-5.24.0.drv-0/kcoreaddons-5.24.0/autotests/kprocesstest.cpp(69)]
PASS   : KProcessTest::test_setShellCommand()
PASS   : KProcessTest::cleanupTestCase()
Totals: 3 passed, 1 failed, 0 skipped, 0 blacklisted
********* Finished testing of KProcessTest *********

[-- Attachment #2: 0001-gnu-kde-frameworks-Add-kwidgetsaddons.patch --]
[-- Type: text/x-patch, Size: 2732 bytes --]

From 64e2334454e6fa9e6160045b78d485458b57514d Mon Sep 17 00:00:00 2001
From: David Craven <david@craven.ch>
Date: Sun, 12 Jun 2016 20:49:12 +0200
Subject: [PATCH] gnu: kde-frameworks: Add kwidgetsaddons.

* gnu/packages/kde-frameworks.scm (kwidgetsaddons): New variable.

Co-authored-by: Hartmut Goebel <h.goebel@crazy-compilers.com>
---
 gnu/packages/kde-frameworks.scm | 43 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index c10356a..c5350d6 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -734,6 +734,49 @@ are adjusted to be what a Qt developer expects - two arguments of int are
 represented by a QPoint or a QSize.")
     (license license:lgpl2.1+)))
 
+(define-public kwidgetsaddons
+  (package
+    (name "kwidgetsaddons")
+    (version "5.24.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "mirror://kde/stable/frameworks/"
+                            (version-major+minor version) "/"
+                            name "-" version ".tar.xz"))
+        (sha256
+         (base32
+          "1kppx0ppfhnb6q6sijs2dffyar86wkkx8miqavsjsgw1l2wiymcx"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("qttools" ,qttools)
+       ("xorg-server" ,xorg-server)))
+    (inputs
+     `(("qtbase" ,qtbase)))
+    (arguments ; FIXME libGL error: failed to load driver: swrast
+     `(#:phases
+        (modify-phases %standard-phases
+          (add-before 'check 'check-setup
+            (lambda* _
+              (setenv "CTEST_OUTPUT_ON_FAILURE" "1") ; enable debug output
+              (setenv "LIBGL_DEBUG" "verbose") ; enable debug output
+              (setenv "DBUS_FATAL_WARNINGS" "0")))
+          (add-before 'check 'start-xorg-server
+            (lambda* (#:key inputs #:allow-other-keys)
+              ;; The test suite requires a running X server.
+              (system (string-append (assoc-ref inputs "xorg-server")
+                                     "/bin/Xvfb :1 &"))
+              (setenv "DISPLAY" ":1")
+             #t)))))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Large set of desktop widgets")
+    (description "Provided are action classes that can be added to toolbars or
+menus, a wide range of widgets for selecting characters, fonts, colors, actions,
+dates and times, or MIME types, as well as platform-aware dialogs for
+configuration pages, message boxes, and password requests.")
+    (license license:lgpl2.1+)))
+
 (define-public kwindowsystem
   (package
     (name "kwindowsystem")
-- 
2.9.0


[-- Attachment #3: 0001-gnu-kde-frameworks-Add-kcoreaddons.patch --]
[-- Type: text/x-patch, Size: 2586 bytes --]

From f00ac9336c2c8c47a14a647c3f22ed09064a04aa Mon Sep 17 00:00:00 2001
From: David Craven <david@craven.ch>
Date: Sun, 12 Jun 2016 20:39:34 +0200
Subject: [PATCH] gnu: kde-frameworks: Add kcoreaddons.

* gnu/packages/kde-frameworks.scm (kcoreaddons): New variable.

Co-authored-by: Hartmut Goebel <h.goebel@crazy-compilers.com>
---
 gnu/packages/kde-frameworks.scm | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index d6a7636..540610f 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -349,6 +349,46 @@ propagate their changes to their respective configuration files.")
                    license:lgpl3+ license:gpl1 ; licende:mit-olif
                    license:bsd-2 license:bsd-3))))
 
+(define-public kcoreaddons
+  (package
+    (name "kcoreaddons")
+    (version "5.24.0")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (string-append "mirror://kde/stable/frameworks/"
+                            (version-major+minor version) "/"
+                            name "-" version ".tar.xz"))
+        (sha256
+         (base32
+          "06sx7by3nvaridnavj5p0bxv4nh47n708jlacfw8ydaikmd9i03h"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("qttools" ,qttools)
+       ("xorg-server" ,xorg-server))) ; for the tests
+    (inputs
+     `(("qtbase" ,qtbase)))
+    (arguments
+     `(#:phases
+        (modify-phases %standard-phases
+          (add-before 'check 'check-setup
+            (lambda* _
+              (setenv "CTEST_OUTPUT_ON_FAILURE" "1") ; enable debug output
+              (setenv "HOME" (getcwd))
+              (setenv "TMPDIR" (getcwd)))))))
+    ; FIXME test failure because stout/stderr are piped to the same file
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "Qt addon library with a collection of non-GUI utilities")
+    (description "KCoreAddons provides classes built on top of QtCore to
+perform various tasks such as manipulating mime types, autosaving files,
+creating backup files, generating random sequences, performing text
+manipulations such as macro replacement, accessing user information and
+many more.")
+    ;; Some source files mention lgpl2.0+, but the included license is
+    ;; the lgpl2.1. Some source files are under non-copyleft licenses.
+    (license license:lgpl2.1+)))
+
 (define-public kwindowsystem
   (package
     (name "kwindowsystem")
-- 
2.9.0