From: David Craven <david@craven.ch>
To: Chris Marusich <cmmarusich@gmail.com>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH 2/2] system: Add btrfs file system support.
Date: Fri, 2 Dec 2016 17:27:24 +0100 [thread overview]
Message-ID: <CAL1_im=MEq8OweBX+0QoVh8foLiKk-thpd-O6=SjUYVakNpiuQ@mail.gmail.com> (raw)
In-Reply-To: <87zikeposs.fsf@gmail.com>
> How to handle the return codes.
This isn't a problem, the check-procedure can normalize the return codes. The
confusing thing is this part:
(else #~(system* (string-append "fsck." type) device)
The default behavior should be to emit a warning to stderr and do nothing. I
don't think this produces anything useful for any file system...
> I've also wondered about this. I'm not sure how long each test takes to
> run, so an analysis of the tests to find their slow areas might help
> guide us.
I noticed that the system tests in general are fast. It's only the
installer tests that take so long.
next prev parent reply other threads:[~2016-12-02 16:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 18:36 [PATCH 1/2] gnu: Add btrfs-progs/static David Craven
2016-11-30 18:36 ` [PATCH 2/2] system: Add btrfs file system support David Craven
2016-12-01 19:18 ` Marius Bakke
2016-12-02 10:50 ` David Craven
2016-12-02 11:12 ` Chris Marusich
2016-12-02 16:27 ` David Craven [this message]
2016-12-03 15:21 ` Ludovic Courtès
2016-12-03 15:18 ` Ludovic Courtès
2016-12-03 15:31 ` Ludovic Courtès
2016-12-03 16:21 ` David Craven
2016-12-05 20:44 ` Ludovic Courtès
2016-12-03 15:15 ` [PATCH 1/2] gnu: Add btrfs-progs/static Ludovic Courtès
2016-12-03 21:41 ` David Craven
2016-12-05 20:51 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL1_im=MEq8OweBX+0QoVh8foLiKk-thpd-O6=SjUYVakNpiuQ@mail.gmail.com' \
--to=david@craven.ch \
--cc=cmmarusich@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.