From: "Thompson, David" <dthompson2@worcester.edu>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCHES] Upgrade Kodi to 16.0
Date: Mon, 14 Mar 2016 15:14:21 -0400 [thread overview]
Message-ID: <CAJ=RwfaPcoqhT5D2kbdj-FFEVnNZW1qTg93zsPJpLTQtQ0JQAQ@mail.gmail.com> (raw)
In-Reply-To: <87vb4q4top.fsf@elephly.net>
On Sun, Mar 13, 2016 at 5:24 AM, Ricardo Wurmus <rekado@elephly.net> wrote:
>
> Thompson, David <dthompson2@worcester.edu> writes:
>
>> Hello Mathieu,
>>
>> On Sat, Mar 12, 2016 at 3:10 PM, Mathieu Lirzin <mthl@gnu.org> wrote:
>>> Hello David,
>>>
>>> David Thompson <dthompson2@worcester.edu> writes:
>>>
>>>>From 80f08dde121610dcc832f4e6ecdd11341166580c Mon Sep 17 00:00:00 2001
>>>> From: David Thompson <dthompson2@worcester.edu>
>>>> Date: Sat, 12 Mar 2016 12:23:47 -0500
>>>> Subject: [PATCH 1/3] gnu: Add crossguid.
>>>>
>>>> * gnu/packages/kodi.scm (crossguid): New variable.
>>>> ---
>>> [...]
>>>> +(define-public crossguid
>>>> + (let ((commit "8f399e8bd4252be9952f3dfa8199924cc8487ca4"))
>>>> + (package
>>>> + (name "crossguid")
>>>> + (version (string-append "0.0-1." (string-take commit 7)))
>>>> + ;; There's no official release. Just a Git repository.
>>>> + (source (origin
>>>> + (method git-fetch)
>>>> + (uri (git-reference
>>>> + (url "https://github.com/graeme-hill/crossguid.git")
>>>> + (commit commit)))
>>>> + (sha256
>>>> + (base32
>>>> + "1i29y207qqddvaxbn39pk2fbh3gx8zvdprfp35wasj9rw2wjk3s9"))))
>>>
>>> You have omitted “(file-name (string-append name "-" version ".tar.gz"))”.
>>
>> Not in this case because it's a git checkout, not a tarball download.
>
> Shouldn’t it be named “...-checkout” then? We do this a lot in the
> bioinformatics.scm module.
It already gets a name like that without having to do anything.
I've pushed the patches. I can push an additional fix if it turns out
that something really ought to be changed with the directory name of
the git checkout.
- Dave
next prev parent reply other threads:[~2016-03-14 19:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-12 17:27 [PATCHES] Upgrade Kodi to 16.0 David Thompson
2016-03-12 20:10 ` Mathieu Lirzin
2016-03-13 1:02 ` Thompson, David
2016-03-13 9:24 ` Ricardo Wurmus
2016-03-14 19:14 ` Thompson, David [this message]
2016-03-14 21:53 ` Mathieu Lirzin
2016-03-15 16:17 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ=RwfaPcoqhT5D2kbdj-FFEVnNZW1qTg93zsPJpLTQtQ0JQAQ@mail.gmail.com' \
--to=dthompson2@worcester.edu \
--cc=guix-devel@gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.