From: "Thompson, David" <dthompson2@worcester.edu>
To: Efraim Flashner <efraim@flashner.co.il>,
Maxime Devos <maximedevos@telenet.be>,
zimoun <zimon.toutoune@gmail.com>,
25957@debbugs.gnu.org
Subject: bug#25957: [EXT] bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks
Date: Thu, 1 Sep 2022 09:59:55 -0400 [thread overview]
Message-ID: <CAJ=RwfZ59KTZ=9z3j6tF9AcGteW+jmaDphqy_XD4uDXB_XbyQA@mail.gmail.com> (raw)
In-Reply-To: <YkFaedjhpznFqbNM@3900XT>
Hi all,
Reviving this old thread.
On Mon, Mar 28, 2022 at 2:51 AM Efraim Flashner <efraim@flashner.co.il> wrote:
> >
> > Seems like all we have to do is 'substitute*' a '/usr/bin/svnserve'
> > into a '/gnu/store/...' (untested), so seems actionable to me.
> > Alternatively, as Efraim wrote, let it search the $PATH (that might be
> > useful if adding svnserve would increase the closure too much and it is
> > an optional dependency in practice?).
>
> I spent some time looking at gitolite and the service. As I understand
> it, with the exception of svnserve, it searches $PATH for a number of
> different binaries, including git-annex. I believe that this would only
> work if git-annex (and potentially other packages) are installed
> globally.
>
> In addition, git (not git-minimal) and openssh are propagated inputs AND
> wrapped. I haven't tested to see if wrapping only is enough.
>
> I think the best choice is to:
> A: Replace /usr/bin/svnserve with svnserve so it will just search $PATH,
> like it does with the other helpers.
I see that you have done this. Thanks! We could also replace the
reference to /usr/sbin/redis-server in src/lib/Gitolite/Cache.pm.
That's the only other /usr reference I can find (that isn't in a
comment) in the output. I have the patch ready if that sounds good to
you.
> B: Adjust the service so that it automatically creates a variant (or
> just a wrapped version) of the package which is wrapped with a list of
> additional packages so that they can be in gitolite's path. If I were
> deploying this to an arm device I wouldn't want it wrapped with
> git-annex since it doesn't build, but would definitely want it for an
> x86_64 machine.
The service configuration record could accept a list of addons like
'(git-annex cache svnserve), with a default of no addons '(), and
create a package that extends the gitolite package with the
appropriate propagated inputs. Does that sound like what you had in
mind? A more robust solution could modify the build to hardcode the
store paths needed for the add-ons but given that we already propagate
git and openssh I don't think it's necessary right now.
> I suppose we should try to find someone who is using the gitolite
> service and see if they can be our test subject for wrapping the package
> with optional addons.
I use the gitolite service and can be the test subject. I don't
currently use any add-ons, but the redis one sounds easy enough to try
and hey maybe it's a good excuse to finally learn how to use
git-annex.
As a longer term thing, it would be cool to revisit propagating git
and openssh in this package. I punted on it back in 2015 for the
reason stated in the source comments but maybe there's a reasonable
and reliable way to directly embed the store paths now.
- Dave
next prev parent reply other threads:[~2022-09-01 14:01 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 21:58 bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks ng0
[not found] ` <handler.25957.B.14885741929377.ack@debbugs.gnu.org>
2017-03-03 22:27 ` bug#25957: Acknowledgement (gitolite broken: created repositories keep references to /usr/bin for hooks) ng0
2017-03-04 13:32 ` ng0
2017-03-04 15:43 ` Danny Milosavljevic
2017-03-04 17:33 ` ng0
2022-01-05 0:07 ` bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks zimoun
2022-01-12 18:07 ` Efraim Flashner
2022-02-03 2:49 ` zimoun
2022-03-23 10:45 ` zimoun
2022-03-23 12:44 ` Maxime Devos
2022-03-28 6:49 ` Efraim Flashner
2022-06-23 9:35 ` Seek Gitolite users (was bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks) zimoun
2022-06-23 11:07 ` Julien Lepiller
2022-09-01 13:59 ` Thompson, David [this message]
2022-09-01 14:20 ` bug#25957: [EXT] bug#25957: gitolite broken: created repositories keep references to /usr/bin for hooks Efraim Flashner
2022-09-01 14:41 ` bug#25957: [EXT] " Thompson, David
2022-09-01 17:00 ` zimoun
2022-09-02 6:56 ` Efraim Flashner
2022-09-02 11:11 ` Thompson, David
2022-09-02 12:41 ` Efraim Flashner
2022-09-02 12:50 ` bug#25957: [EXT] " Thompson, David
2022-09-02 19:58 ` Thompson, David
2022-09-04 7:26 ` Efraim Flashner
2022-09-04 13:26 ` Thompson, David
2022-09-05 8:16 ` zimoun
2022-09-06 13:50 ` Thompson, David
2022-10-06 13:26 ` Thompson, David
2022-10-06 13:42 ` Thompson, David
2022-10-08 14:56 ` zimoun
2022-10-09 1:40 ` Thompson, David
2022-10-24 21:21 ` Thompson, David
2022-10-25 9:58 ` zimoun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ=RwfZ59KTZ=9z3j6tF9AcGteW+jmaDphqy_XD4uDXB_XbyQA@mail.gmail.com' \
--to=dthompson2@worcester.edu \
--cc=25957@debbugs.gnu.org \
--cc=efraim@flashner.co.il \
--cc=maximedevos@telenet.be \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.