all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Catonano <catonano@gmail.com>
To: nee <nee@cock.li>
Cc: 29938@debbugs.gnu.org
Subject: [bug#29938] [PATCH 3/3] gnu: Add sound-juicer.
Date: Thu, 4 Jan 2018 09:17:30 +0100	[thread overview]
Message-ID: <CAJ98PDy_rZe_2nA9JKCSybrw9s4RL-hmhcHLKyK8XxACytQxFw@mail.gmail.com> (raw)
In-Reply-To: <733478d3-af7f-1b9b-17ee-c6be39559b0d@cock.li>

[-- Attachment #1: Type: text/plain, Size: 2018 bytes --]

2018-01-04 4:30 GMT+01:00 nee <nee@cock.li>:

> Am 02.01.2018 um 17:35 schrieb Catonano:
> > Now, guix size sound-juicer: is this good or bad ? I didn't use guix
> > size so often in the past so I'm not sure about this result
> >
> > [env]$ ./pre-inst-env guix size sound-juicer
> > ...
> I generally feel like a lot of packages pull too many
> dependencies right now and that this should be improved.
>
> > I wonder what in sound-juicer transitive closure depends on llvmm ?
>
> It is required for mesa which is required by gtk+
>

Ah ok


> > Cairo 2 times with  different hashes ?
>
> Also appears in gtk+, but I haven't checked where exactly it comes from.
>

Interesting



> > ghostscript with cups ? Bah
> >
> That probably comes from some kind of doc builder for something gtk
> related AFAIK.
>

Ok


>
> > /gnu/store/h15r555pry7i274zw1afhcv0c0ni2bbc-brasero-3.12.2
> > 787.7    13.5   1.6%
> >
> > The whole Brasero ? Wow
> >
>
> It needs to link the libbrasero libraries.
> I shortly tried to split brasero libraries into a separate outputs
> today, but I failed because one of the libraries references the icon
> directory and I'm also not sure if it's worth bothering with too much.
>

I agree



> > total: 818.5 MiB
> >
> > is this acceptable ? I don't know
> `guix size gtk+` takes 680 MiB and gtk+ is responsible for most of the
> "WTF" dependencies. I wonder if it could be split up like qt.
> I used guix graph and a little time scrolling on a gigantic image to
> figure out that out.
>

When I have played with the nodejs graph, it was too big for Graphviz t
oprocess it and visualizing it was a challenge
We probably need something better to visualize graphs and spot patterns


> The rest probably comes from gstreamer and seems acceptable to me.
>
> I would say this patch is okay, unless you know something that can be
> done directly on the sound-juicer package.
>

No, this patch is ok for me too
As I said, I' m just new at this

As far as I am concerned, LGTM

Thanks for your work !

Ciao

[-- Attachment #2: Type: text/html, Size: 3846 bytes --]

  reply	other threads:[~2018-01-04  8:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-02  0:54 [bug#29938] [PATCH] gnu: Add sound-juicer and it's dependencies nee
2018-01-02  0:56 ` [bug#29938] [PATCH 1/3] gnu: Add libdiscid nee
2018-01-02  0:56   ` [bug#29938] [PATCH 2/3] gnu: Add libmusicbrainz nee
2018-01-11  9:31     ` Ludovic Courtès
2018-01-02  0:56   ` [bug#29938] [PATCH 3/3] gnu: Add sound-juicer nee
2018-01-02 16:35     ` Catonano
2018-01-02 16:37       ` Catonano
2018-01-04  3:30       ` nee
2018-01-04  8:17         ` Catonano [this message]
2018-01-11  9:35     ` bug#29938: " Ludovic Courtès
2018-01-12 15:33       ` [bug#29938] " nee
2018-01-13 13:50         ` Ludovic Courtès
2018-01-11  9:30   ` [bug#29938] [PATCH 1/3] gnu: Add libdiscid Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJ98PDy_rZe_2nA9JKCSybrw9s4RL-hmhcHLKyK8XxACytQxFw@mail.gmail.com \
    --to=catonano@gmail.com \
    --cc=29938@debbugs.gnu.org \
    --cc=nee@cock.li \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.