all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Bassam Saeed <bassam.saeed@gmail.com>
To: 55710@debbugs.gnu.org
Subject: [bug#55710] [PATCH] gnu: quodlibet: Set GST_PLUGIN_SYSTEM_PATH.
Date: Sun, 29 May 2022 12:03:12 -0400	[thread overview]
Message-ID: <CAHeCkFXt+_H0WAY2pOOAtQTMTcgdNH4sW1Vwv7rxmg2f4SniDA@mail.gmail.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 594 bytes --]

Hi all,

Currently, quodlibet is unable to find a gstreamer audio sink when playing
audio unless the relevant gst-plugins is explicitly installed in your
profile. For me that's gst-plugins-good. Currently, existing packaged
applications such as Strawberry and Clementine explicitly set the
GST_PLUGIN_SYSTEM_PATH. I've adapted this for Quodlibet with my patch. I
suppose an alternative might be to include the gst plugins as
propagated-inputs but I'm not certain about that. I decided to just follow
the current practice.

Hope everything is right here. My first patch to guix.

Cheers,
Bassam

[-- Attachment #1.2: Type: text/html, Size: 725 bytes --]

[-- Attachment #2: 0001-gnu-quodlibet-Set-GST_PLUGIN_SYSTEM_PATH.patch --]
[-- Type: text/x-patch, Size: 1297 bytes --]

From 1c0a33328b3475f39d10d9a668ba11f702b962dd Mon Sep 17 00:00:00 2001
Message-Id: <1c0a33328b3475f39d10d9a668ba11f702b962dd.1653839478.git.bassam.saeed@gmail.com>
From: Bassam Saeed <bassam.saeed@gmail.com>
Date: Sun, 29 May 2022 11:35:57 -0400
Subject: [PATCH] gnu: quodlibet: Set GST_PLUGIN_SYSTEM_PATH.

---
 gnu/packages/music.scm | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 9011f262a4..b4ff2bef0e 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -6904,6 +6904,13 @@ (define-public quodlibet
                            ,@%glib-or-gtk-build-system-modules)
       #:phases
       #~(modify-phases %standard-phases
+          (add-after 'install 'wrap-program
+            (lambda* (#:key inputs outputs #:allow-other-keys)
+              (let ((out             (assoc-ref outputs "out"))
+                    (gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH")))
+                (wrap-program (string-append out "/bin/quodlibet")
+                  `("GST_PLUGIN_SYSTEM_PATH" ":" prefix (,gst-plugin-path)))
+                #t)))
           (add-before 'check 'pre-check
             (lambda _
               (setenv "HOME" (getcwd))))

base-commit: 9cd22702b87f873f7e307c99b406fb758e5a307c
-- 
2.36.1


             reply	other threads:[~2022-05-29 19:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-29 16:03 Bassam Saeed [this message]
2022-05-30 19:54 ` bug#55710: [PATCH] gnu: quodlibet: Set GST_PLUGIN_SYSTEM_PATH Liliana Marie Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHeCkFXt+_H0WAY2pOOAtQTMTcgdNH4sW1Vwv7rxmg2f4SniDA@mail.gmail.com \
    --to=bassam.saeed@gmail.com \
    --cc=55710@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.