From: Rostislav Svoboda <rostislav.svoboda@gmail.com>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 54852@debbugs.gnu.org
Subject: [bug#54852] [PATCH] gnu: Add openjdk18.
Date: Tue, 10 May 2022 00:20:24 +0200 [thread overview]
Message-ID: <CAEtmmez=WOj7KCips=LR1aiikkmAhTioDOv=oBKw7gy5-uMUkw@mail.gmail.com> (raw)
In-Reply-To: <d1fd3fb876bd26c7dc1e9685daf362bcba43a767.camel@telenet.be>
Hi Maxime,
> The following simplified package definition ‘worked’ for me:
>
> (define-public openjdk18
> (package
> (inherit openjdk17)
> (name "openjdk")
> (version "18")
> (source (origin
> (method git-fetch)
> (uri (git-reference
> (url "https://github.com/openjdk/jdk18u")
> (commit (string-append "jdk-" version "-ga"))))
> (file-name (git-file-name name version))
> (sha256
> (base32
> "1bv6bdhkmwvn10l0xy8yi9xibds640hs5zsvx0jp7wrxa3qw4qy8"))))
> (native-inputs
> (modify-inputs (package-native-inputs openjdk17)
> (replace "openjdk16:jdk" openjdk17)))
> [home-page ...]))
I'm a bit puzzled. Here is how I run the build:
The `/home/bost/dev/guix` contains a clone of
https://git.savannah.gnu.org/git/guix.git
```shell
$ pwd
/home/bost/dev/guix/gnu/packages
$ time guix build --check --load-path=. openjdk
...
Executed in 73.08 secs fish external
usr time 151.31 secs 0.00 micros 151.31 secs
sys time 0.48 secs 759.00 micros 0.48 secs
```
So my build time is about 2,5 minutes. During the build I get plenty
of warnings like:
guix build: warning: failed to load '(SOME-THING)':
no code for module (SOME-THING)
./SOME-THING.scm:20:0: warning: module name (gnu packages
SOME-THING) does not match file name 'SOME-THING.scm'
hint: File `./SOME-THING.scm' should probably start with:
(define-module (SOME-THING))
and it looks like the warnings can be ignored.
Regarding the compilation itself, first of all I had to exclude the
271b2e43bef96f17f3f1e1085394b4bb144c5768 due to the
https://issues.guix.gnu.org/55255 from my repo.
Then I had to fix the `[home-page ...]` and put there `(home-page
"https://openjdk.java.net/projects/jdk/18")` and even after that it
doesn't compile. I get:
The following graft will be made:
/gnu/store/42kdy7fs7pykx79m69v2gpxw7gmph745-openjdk-18.drv
guix build: error: some outputs of
`/gnu/store/42kdy7fs7pykx79m69v2gpxw7gmph745-openjdk-18.drv' are not
valid, so checking is not possible
And here are the definitions which work for me:
;; I'd prefer:
(define-public openjdk18
(package
(inherit openjdk17)
(name "openjdk")
(version "18")
(source (origin
(method git-fetch)
(uri (git-reference
(url "https://github.com/openjdk/jdk18u")
(commit (string-append "jdk-" version "-ga"))))
(file-name (git-file-name name version))
(sha256
(base32
"1bv6bdhkmwvn10l0xy8yi9xibds640hs5zsvx0jp7wrxa3qw4qy8"))))
(native-inputs
(map (lambda (input)
(match (car input)
("openjdk16:jdk" `("openjdk17:jdk" ,openjdk17 "jdk"))
(_ input)))
(package-native-inputs openjdk17)))
(home-page "https://openjdk.java.net/projects/jdk/18")))
;; This works too:
(define-public openjdk18
(package
(inherit openjdk17)
(name "openjdk")
(version "18")
(source (origin
(method git-fetch)
(uri (git-reference
(url "https://github.com/openjdk/jdk18u")
(commit (string-append "jdk-" version "-ga"))))
(file-name (git-file-name name version))
(sha256
(base32
"1bv6bdhkmwvn10l0xy8yi9xibds640hs5zsvx0jp7wrxa3qw4qy8"))))
(modify-inputs (package-native-inputs openjdk17)
(delete "openjdk16:jdk")
(append `(("openjdk17:jdk" ,openjdk17 "jdk"))))
(home-page "https://openjdk.java.net/projects/jdk/18")))
> About the labels issue: maybe "icedtea-8" could be changed to "icedtea",
> "openjdkN" to "openjdk" and "openjdkN:jdk" to "openjdk:jdk" at some point
> in the future, such that the package name matches the input label and
> the input alist can be changed to a package list.
Sure. Good idea.
Greetings,
Bost
next prev parent reply other threads:[~2022-05-09 22:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 12:53 [bug#54852] [PATCH] gnu: Add openjdk18 Rostislav Svoboda
2022-04-11 13:43 ` Maxime Devos
2022-04-12 13:03 ` Rostislav Svoboda
2022-04-11 13:44 ` Maxime Devos
2022-04-12 13:24 ` Rostislav Svoboda
2022-04-21 10:27 ` Rostislav Svoboda
2022-04-21 16:38 ` Maxime Devos
2022-04-22 10:59 ` Rostislav Svoboda
2022-04-23 14:38 ` Maxime Devos
2022-04-23 15:11 ` Rostislav Svoboda
2022-04-23 16:10 ` Maxime Devos
2022-04-11 14:15 ` Julien Lepiller
2022-04-13 7:51 ` Björn Höfling
2022-05-08 16:41 ` Maxime Devos
2022-05-09 19:11 ` Maxime Devos
2022-05-09 22:20 ` Rostislav Svoboda [this message]
2022-05-10 6:59 ` Maxime Devos
2022-05-11 15:37 ` Rostislav Svoboda
2022-05-11 18:13 ` Maxime Devos
2022-05-11 18:22 ` Maxime Devos
2022-05-11 18:30 ` Maxime Devos
2022-09-27 14:17 ` bug#54852: " Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEtmmez=WOj7KCips=LR1aiikkmAhTioDOv=oBKw7gy5-uMUkw@mail.gmail.com' \
--to=rostislav.svoboda@gmail.com \
--cc=54852@debbugs.gnu.org \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.