From: "Gábor Boskovits" <boskovits@gmail.com>
To: Chris Marusich <cmmarusich@gmail.com>
Cc: 29897@debbugs.gnu.org
Subject: [bug#29897] [PATCH core-updates] gnu: java-aqute-libg: Fix compilation on java8.
Date: Wed, 17 Jan 2018 13:15:56 +0100 [thread overview]
Message-ID: <CAE4v=piHL3k237tULxQTR7qbhXfnFy-JRM7nsw+9CT8ggajuZA@mail.gmail.com> (raw)
In-Reply-To: <87zi5cga5w.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1460 bytes --]
2018-01-17 9:30 GMT+01:00 Chris Marusich <cmmarusich@gmail.com>:
> Gábor Boskovits <boskovits@gmail.com> writes:
>
> > * gnu/packages/java.scm (java-aqute-libg)[arguments]: Add keyword
> make-flags to use
> > source and target 1.7.
>
> As a matter of Git style, the first line of a commit message should not
> be longer than about 50 characters, and it should not span more than 1
> line. Maybe we could replace the first line with the following instead?
>
> gnu: java-aqute-libg: Explicitly build for Java 7.
>
> In addition, the comment in the commit message is helpful, but it would
> be better to move it or copy it into the actual source code. That way,
> when somebody reads the source, they'll know immediately why we
> explicitly build for Java 7 without having to resort to searching the
> Git history.
>
> > + #:make-flags (list (string-append "-Dant.build.javac.source="
> "1.7")
> > + (string-append "-Dant.build.javac.target="
> "1.7"))
>
> You can also write this list in the following form, which is simpler:
>
> (list "-Dant.build.javac.source=1.7" "-Dant.build.javac.target=1.7")
>
> I'll make these changes and commit this in the next day or two, unless
> you have additional comments or you submit a new patch before then.
>
> -
> Chris
>
Thanks for the corrections.
Looks good to me,
I won't send an updated patch then.
Please commit with the modifications.
[-- Attachment #2: Type: text/html, Size: 2134 bytes --]
next prev parent reply other threads:[~2018-01-17 12:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-29 19:17 [bug#29897] [PATCH core-updates] gnu: java-aqute-libg: Fix compilation on java8 Gábor Boskovits
2018-01-17 8:30 ` Chris Marusich
2018-01-17 12:15 ` Gábor Boskovits [this message]
2018-01-25 9:30 ` Chris Marusich
2018-01-25 21:47 ` Gábor Boskovits
2018-01-26 9:58 ` Gábor Boskovits
2018-01-26 10:33 ` Gábor Boskovits
2018-06-24 16:13 ` bug#29897: " Gábor Boskovits
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE4v=piHL3k237tULxQTR7qbhXfnFy-JRM7nsw+9CT8ggajuZA@mail.gmail.com' \
--to=boskovits@gmail.com \
--cc=29897@debbugs.gnu.org \
--cc=cmmarusich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.