[bug#55663] [PATCH] Image API: add FAT32 support

[Pavel Shlyak <p.shlyak@pantherx.org>]

[-- Attachment #1: 0001-guix-Image-API-support-FAT32-partitions.patch --]
[-- Type: application/octet-stream, Size: 3800 bytes --]

From 5ff7fcf80196111ab8d5f87a1d159ed0349153b4 Mon Sep 17 00:00:00 2001
From: Pavel Shlyak <p.shlyak@pantherx.org>
Date: Thu, 26 May 2022 21:00:51 +0300
Subject: [PATCH] guix: Image API: support FAT32 partitions

* gnu/build/image.scm (make-vfat-image): pass fs bits as argument and force 1kb logical sector size only if "ESP" flag is set.
  (make-partition-image): add "fat32" partition type, support explicit "fat16" type with vfat alias.
* gnu/system/image.scm (partition->dos-type partition): return file system IDs for "fat16" and "fat32" partitions.
  (partition->gpt-type partition): ditto.
---
 gnu/build/image.scm  | 24 ++++++++++++++----------
 gnu/system/image.scm |  8 ++++++--
 2 files changed, 20 insertions(+), 12 deletions(-)

diff --git a/gnu/build/image.scm b/gnu/build/image.scm
index 3e8b94e2d6..ddfd34c111 100644
--- a/gnu/build/image.scm
+++ b/gnu/build/image.scm
@@ -95,16 +95,18 @@ (define* (make-ext-image partition target root
                            (estimate-partition-size root)
                            size)))))))
 
-(define* (make-vfat-image partition target root)
+(define* (make-vfat-image partition target root fs-bits)
   "Handle the creation of VFAT partition images.  See 'make-partition-image'."
   (let ((size (partition-size partition))
-        (label (partition-label partition)))
-    (invoke "fakeroot" "mkdosfs" "-n" label "-C" target
-            "-F" "16" "-S" "1024"
-            (size-in-kib
-             (if (eq? size 'guess)
-                 (estimate-partition-size root)
-                 size)))
+        (label (partition-label partition))
+        (flags (partition-flags partition)))
+    (apply invoke "fakeroot" "mkdosfs" "-n" label "-C" target
+                          "-F" (number->string fs-bits)
+                          (size-in-kib
+                           (if (eq? size 'guess)
+                               (estimate-partition-size root)
+                               size))
+                    (if (member 'esp flags) (list "-S" "1024") '()))
     (for-each (lambda (file)
                 (unless (member file '("." ".."))
                   (invoke "mcopy" "-bsp" "-i" target
@@ -120,8 +122,10 @@ (define* (make-partition-image partition-sexp target root)
     (cond
      ((string-prefix? "ext" type)
       (make-ext-image partition target root))
-     ((string=? type "vfat")
-      (make-vfat-image partition target root))
+     ((or (string=? type "vfat") (string=? type "fat16"))
+      (make-vfat-image partition target root 16))
+     ((string=? type "fat32")
+      (make-vfat-image partition target root 32))
      (else
       (raise (condition
               (&message
diff --git a/gnu/system/image.scm b/gnu/system/image.scm
index dd32e58c2d..f02f6e0b8c 100644
--- a/gnu/system/image.scm
+++ b/gnu/system/image.scm
@@ -312,7 +312,9 @@ (define (partition->dos-type partition)
         (cond
          ((member 'esp flags) "0xEF")
          ((string-prefix? "ext" file-system) "0x83")
-         ((string=? file-system "vfat") "0x0E")
+         ((or (string=? file-system "vfat")
+              (string=? file-system "fat16")) "0x0E")
+         ((string=? file-system "fat32") "0x0C")
          (else
           (raise (condition
                   (&message
@@ -329,7 +331,9 @@ (define (partition->gpt-type partition)
         (cond
          ((member 'esp flags) "U")
          ((string-prefix? "ext" file-system) "L")
-         ((string=? file-system "vfat") "F")
+         ((or (string=? file-system "vfat")
+              (string=? file-system "fat16")
+              (string=? file-system "fat32")) "F")
          (else
           (raise (condition
                   (&message
-- 
2.32.1 (Apple Git-133)


[-- Attachment #2: Type: text/plain, Size: 930 bytes --]



> 30 мая 2022 г., в 10:01, Mathieu Othacehe <othacehe@gnu.org> написал(а):
> 
> 
> Hello Pavel,
> 
>> gnu/build/image.scm  | 24 ++++++++++++++----------
>> gnu/system/image.scm |  9 +++++++--
> 
> Please write a commit message following the guidelines available here:
> https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html
> 
>> +(define* (make-vfat-image partition target root fs_bits)
> 
> s/fs_bits/fs-bits/
> 
>> +         ((or (string=? file-system "vfat") (string=? file-system "fat16")) "0x0E")
> 
> This line is longer than 78 characters you can break it between the two
> strings comparisons.
> 
>> +         (
>> +          (or (string=? file-system "vfat")
> 
> Merge those two lines.
> 
>> +              (string=? file-system "fat32")
>> +              ) "F")
> 
> Ditto.
> 
> Can you please send a v2?
> 
> Thanks for your contribution,
> 
> Mathieu