all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Rovanion Luckey <rovanion.luckey@gmail.com>
To: 45542@debbugs.gnu.org
Subject: [bug#45542] import: pypi: Clearify docstring of parse-requires.txt
Date: Tue, 29 Dec 2020 23:54:11 +0100	[thread overview]
Message-ID: <CAAaf0CAUiNFpjqXgEEz17eYVV01fnp65-ZN8kPmGARjSEsAeEA@mail.gmail.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 217 bytes --]

When mucking about the codebase trying to figure out if it would be
possible to automatically import a Python project using Guix preexisting
functions I found a docstring I thought could be more explicit than it was.

[-- Attachment #1.2: Type: text/html, Size: 242 bytes --]

[-- Attachment #2: 0001-import-pypi-Clearify-docstring-on-parse-requires.txt.patch --]
[-- Type: text/x-patch, Size: 933 bytes --]

From 338ac21c68e757d94b8375cb42345a82488f1708 Mon Sep 17 00:00:00 2001
From: Rovanion Luckey <rovanion.luckey@gmail.com>
Date: Thu, 26 Nov 2020 20:59:19 +0100
Subject: [PATCH 1/2] import: pypi: Clearify docstring of parse-requires.txt

---
 guix/import/pypi.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/guix/import/pypi.scm b/guix/import/pypi.scm
index bf4dc50138..6731d50891 100644
--- a/guix/import/pypi.scm
+++ b/guix/import/pypi.scm
@@ -229,8 +229,8 @@ the input field."
        '("test" "dev")))

 (define (parse-requires.txt requires.txt)
-  "Given REQUIRES.TXT, a Setuptools requires.txt file, return a list of lists
-of requirements.
+  "Given REQUIRES.TXT, a path to a Setuptools requires.txt file, return a list
+of lists of requirements.

 The first list contains the required dependencies while the second the
 optional test dependencies.  Note that currently, optional, non-test
--
2.29.2

             reply	other threads:[~2020-12-29 22:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-29 22:54 Rovanion Luckey [this message]
2021-04-23  4:02 ` bug#45542: import: pypi: Clearify docstring of parse-requires.txt Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAaf0CAUiNFpjqXgEEz17eYVV01fnp65-ZN8kPmGARjSEsAeEA@mail.gmail.com \
    --to=rovanion.luckey@gmail.com \
    --cc=45542@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.