all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Julien Lepiller <julien@lepiller.eu>
To: zimoun <zimon.toutoune@gmail.com>,
	Remco van 't Veer <remco@remworks.net>
Cc: 58880@debbugs.gnu.org
Subject: bug#58880: Patch impacting translation (was Re: bug#58880: 'guix gc' does not round the amount of disk space freed)
Date: Sun, 22 Jan 2023 17:43:00 +0100	[thread overview]
Message-ID: <C72D22F0-4EEF-42FC-AB15-AC26EB55289A@lepiller.eu> (raw)
In-Reply-To: <86v8ky1v58.fsf@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 3108 bytes --]

Changing the po files in guix repo will work at first, it'll be negated next time I push changes from weblate. We could change the po files to ensure continuity, but we have to also apply the change to the repo behind weblate. I can take care of it after the patch is pushed.

Le 22 janvier 2023 15:49:55 GMT+01:00, zimoun <zimon.toutoune@gmail.com> a écrit :
>Hi,
>
>On Sat, 21 Jan 2023 at 17:52, Remco van 't Veer <remco@remworks.net> wrote:
>
>>>> * guix/scripts/gc.scm (guix-gc): Round MiBs in user feedback.
>>>> * po/*/*.po (guix/scripts/gc.scm)a: Round MiBs in user feedback.
>>>
>>> If the way to go with the translation dance?
>>
>> I don't know.  I figured since the translation key was changed this
>> would be the best way to do this but to be honest I don't understand how
>> to do this using "weblate" (from info:guix#Translating Guix).
>
>Julien, WDYT?
>
>
>>> The only change is:
>>>
>>>> diff --git a/guix/scripts/gc.scm b/guix/scripts/gc.scm
>>>> index 5e775c5cdb..2bbfb26d5d 100644
>>>> --- a/guix/scripts/gc.scm
>>>> +++ b/guix/scripts/gc.scm
>>>> @@ -260,10 +260,10 @@ (define-command (guix-gc . args)
>>>>      ;; Attempt to have at least SPACE bytes available in STORE.
>>>>      (let ((free (free-disk-space (%store-prefix))))
>>>>        (if (> free space)
>>>> -          (info (G_ "already ~h MiBs available on ~a, nothing to do~%")
>>>> +          (info (G_ "already ~,2h MiBs available on ~a, nothing to do~%")
>>>>                  (/ free 1024. 1024.) (%store-prefix))
>>>>            (let ((to-free (- space free)))
>>>> -            (info (G_ "freeing ~h MiBs~%") (/ to-free 1024. 1024.))
>>>> +            (info (G_ "freeing ~,2h MiBs~%") (/ to-free 1024. 1024.))
>>>>              (collect-garbage store to-free)))))
>>>>
>>>>    (define (delete-generations store pattern)
>>>> @@ -327,10 +327,10 @@ (define-command (guix-gc . args)
>>>>               (ensure-free-space store free-space))
>>>>              (min-freed
>>>>               (let-values (((paths freed) (collect-garbage store min-freed)))
>>>> -              (info (G_ "freed ~h MiBs~%") (/ freed 1024. 1024.))))
>>>> +              (info (G_ "freed ~,2h MiBs~%") (/ freed 1024. 1024.))))
>>>>              (else
>>>>               (let-values (((paths freed) (collect-garbage store)))
>>>> -              (info (G_ "freed ~h MiBs~%") (/ freed 1024. 1024.)))))))
>>>> +              (info (G_ "freed ~,2h MiBs~%") (/ freed 1024. 1024.)))))))
>>>>          ((list-roots)
>>>>           (assert-no-extra-arguments)
>>>>           (list-roots))
>>>
>>> and captured by G_ so does this only to be applied and then all the
>>> msgid updated by the translation process?
>>
>> Yes, this is the only change.  The old keys will be orphaned though and
>> remain in the po files.  I'd be happy to drop the po/*/*.po part of the
>> patch if that helps.
>
>Julien, what is the best solution?  Apply a patch touching all PO files
>or apply a patch touching only the messages captured by G_ and then
>update separately the translations?
>
>
>Cheers,
>simon

[-- Attachment #2: Type: text/html, Size: 4105 bytes --]

  reply	other threads:[~2023-01-22 16:44 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-29 23:50 bug#58880: guix gc notation broken Christian Miller via Bug reports for GNU Guix
2022-10-30  0:12 ` Christian Miller via Bug reports for GNU Guix
2022-11-25 20:33 ` bug#58880: [PATCH] guix gc: Round MiBs in user feedback Remco van 't Veer
2023-01-21 16:26   ` bug#58880: 'guix gc' does not round the amount of disk space freed zimoun
2023-01-21 16:52     ` Remco van 't Veer
2023-01-22 14:49       ` bug#58880: Patch impacting translation (was Re: bug#58880: 'guix gc' does not round the amount of disk space freed) zimoun
2023-01-22 16:43         ` Julien Lepiller [this message]
2023-01-23  7:51           ` zimoun
2023-01-23 13:44             ` bokr
2023-01-24  9:41               ` Simon Tournier
2023-01-23 13:01 ` bug#58880: [PATCH v2 0/2] split into 2 commits and rebased on master Remco van 't Veer
2023-01-23 13:01   ` bug#58880: [PATCH v2 1/2] guix gc: Round MiBs in user feedback Remco van 't Veer
2023-01-23 13:01   ` bug#58880: [PATCH v2 2/2] nls: Update translation keys for guix gc Remco van 't Veer
2023-01-23 13:14     ` Julien Lepiller
2023-01-23 18:16       ` Remco van 't Veer
2023-01-24 15:14     ` pelzflorian (Florian Pelz)
2023-01-25  7:47       ` Remco van 't Veer
2023-05-31 21:41         ` bug#58880: 'guix gc' does not round the amount of disk space freed pelzflorian (Florian Pelz)
2023-01-23 18:17 ` bug#58880: [PATCH v3 1/2] guix gc: Round MiBs in user feedback Remco van 't Veer
2023-01-23 18:17   ` bug#58880: [PATCH v3 2/2] nls: Update translation keys for guix gc Remco van 't Veer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C72D22F0-4EEF-42FC-AB15-AC26EB55289A@lepiller.eu \
    --to=julien@lepiller.eu \
    --cc=58880@debbugs.gnu.org \
    --cc=remco@remworks.net \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.