all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Morgan.J.Smith@outlook.com
To: monego@posteo.net, 51587@debbugs.gnu.org
Subject: [bug#51587] [PATCH v2 0/3] gnu: Add rss2email.
Date: Thu, 11 Nov 2021 10:30:02 -0500	[thread overview]
Message-ID: <BYAPR05MB40237185E859D1D6C966B9D1C5949@BYAPR05MB4023.namprd05.prod.outlook.com> (raw)
In-Reply-To: <BYAPR05MB4023765B9C648E76EF5B2B7AC58C9@BYAPR05MB4023.namprd05.prod.outlook.com>

Thanks for the review!

I looked over both previously submitted sgmllib3k packages and I think my patch is the best as the description mentions SGML.

I fixed the sgmllib3k indentation issue and added a missing word to the description.

For the rss2email patch:
- I added my copyright to mail.scm
- I removed the inputs and outputs from the check phase
- Made the input not propagated. It is indeed a binary that seems to still work this way.
- Fixed that comment
- Slightly modified the description but I'm honestly not sure what the issue is. I'll admit I'm not very good at english so if you could just change it how you see fit that would make me happy


[PATCH v2 1/3] gnu: Add python-sgmllib3k.
[PATCH v2 2/3] gnu: python-feedparser: Add input
[PATCH v2 3/3] gnu: Add rss2email.





      parent reply	other threads:[~2021-11-11 15:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-03 16:27 [bug#51587] [PATCH 0/3] Add rss2email Morgan.J.Smith
2021-11-03 16:37 ` [bug#51587] [PATCH 1/3] gnu: Add python-sgmllib3k Morgan.J.Smith
2021-11-05 15:35   ` Vinicius Monego
2021-11-11 15:30 ` Morgan.J.Smith [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR05MB40237185E859D1D6C966B9D1C5949@BYAPR05MB4023.namprd05.prod.outlook.com \
    --to=morgan.j.smith@outlook.com \
    --cc=51587@debbugs.gnu.org \
    --cc=monego@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.