From: Eric Bavier <bavier@cray.com>
To: Mark H Weaver <mhw@netris.org>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>
Subject: Re: 01/01: gnu: fftw: Build SIMD codelets.
Date: Wed, 9 May 2018 02:29:48 +0000 [thread overview]
Message-ID: <BN7PR11MB2834DE393CDFC49CF7AA1305B7990@BN7PR11MB2834.namprd11.prod.outlook.com> (raw)
In-Reply-To: <87h8nhk9q7.fsf@netris.org>
Hello Mark,
No problem. I don't mind some parallel work that results in more confidence in the changes.
I saw your commit 69d5909, which looks good to me (you even untangled my nasty quoting, which I often can't seem to get right).
Sorry for the slow response, and thanks for finding the issue in the first place.
Eric Bavier, Scientific Libraries, Cray Inc.
________________________________________
From: Mark H Weaver <mhw@netris.org>
Sent: Tuesday, May 8, 2018 18:29
To: Eric Bavier
Cc: guix-devel@gnu.org
Subject: Re: 01/01: gnu: fftw: Build SIMD codelets.
Hi Eric,
Eric Bavier <bavier@cray.com> writes:
> Ok, if you feel confident, that's fine with me.
>
> Otherwise, I have a patch that I've tested on x86-64, and in the
> middle of testing for armhf that I can push in a few hours. I could
> easily add a commit that remove the "--enable-armv7a-cntvct" flag.
Sorry for the duplicate work, but I already pushed my fixes in commit
69d5909e032e2fba57814ea9db52389d384d9341 to core-updates. I tested them
on x86_64, but nowhere else. It's not ideal, and I certainly wouldn't
do such a thing on 'master', but given the large number of affected
builds and my uncertainty about when you would fix it, I didn't want to
wait any longer.
FYI, I also removed "--enable-armv8-cntvct-el0" on 64-bit ARM, because
<https://github.com/FFTW/fftw3/blob/master/README-perfcnt.md> suggests
that as on 32-bit ARM, the relevant instruction is not normally
available from user mode.
I removed "--enable-mips-zbus-timer" on MIPS as well, because I suspect
that it's not supported on Loongson devices, although I'm not certain.
If you see any problems with my commit, please let me know.
Thanks!
Mark
prev parent reply other threads:[~2018-05-09 2:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180417212549.1283.62731@vcs0.savannah.gnu.org>
[not found] ` <20180417212551.BB270208E4@vcs0.savannah.gnu.org>
2018-05-03 23:25 ` 01/01: gnu: fftw: Build SIMD codelets Mark H Weaver
2018-05-04 14:44 ` Eric Bavier
2018-05-08 20:56 ` Mark H Weaver
2018-05-08 21:01 ` Eric Bavier
2018-05-08 23:29 ` Mark H Weaver
2018-05-09 2:29 ` Eric Bavier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN7PR11MB2834DE393CDFC49CF7AA1305B7990@BN7PR11MB2834.namprd11.prod.outlook.com \
--to=bavier@cray.com \
--cc=guix-devel@gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.