all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Efraim Flashner <efraim@flashner.co.il>
To: "Ludovic Courtès" <ludo@gnu.org>,
	"Vivien Kraus" <vivien@planete-kraus.eu>
Cc: 51890@debbugs.gnu.org
Subject: [bug#51890] Vigra: disable more failing tests on core-updates-frozen
Date: Thu, 18 Nov 2021 09:17:03 +0000	[thread overview]
Message-ID: <BF396FC9-4391-4001-AFD1-937A5EBCB2C8@flashner.co.il> (raw)
In-Reply-To: <87a6i1rfs1.fsf_-_@gnu.org>



On November 18, 2021 9:09:50 AM UTC, "Ludovic Courtès" <ludo@gnu.org> wrote:
>Hi,
>
>Vivien Kraus <vivien@planete-kraus.eu> skribis:
>
>> From 4311c36dcd280ba385a3d0f33800428102bef0b8 Mon Sep 17 00:00:00 2001
>> From: Vivien Kraus <vivien@planete-kraus.eu>
>> Date: Tue, 16 Nov 2021 08:18:42 +0000
>> Subject: [PATCH] gnu: vigra: Disable more failing tests.
>>
>> * gnu/packages/image.scm (vigra) [phase disable-broken-tests]: Also disable
>> test2, test3, test_arraytypes and test_multidef.
>
>Looks like it was worked around by disabling NumPy support in Vigra, in
>commit 94b76dc85ca3098bf4ceb0f5b884b5708b9e8134.
>
>I’m not sure how NumPy is used; is there a preference between these two
>options (disabling flaky tests and removing the dependency on NumPy)?
>
>Thanks,
>Ludo’.

It looked to me like vigra was limping along and numpy compatibility was being dragged along by patches here and there. When I built the dependencies of vigra nothing failed to build. I'm definitely not against reinstating support for numpy but I'm not sure just disabling the tests is the right way.

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.




  reply	other threads:[~2021-11-18  9:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-16 11:12 [bug#51890] Vigra: disable more failing tests on core-updates-frozen Vivien Kraus via Guix-patches via
     [not found] ` <handler.51890.B.163706156122505.ack@debbugs.gnu.org>
2021-11-17  8:54   ` Vivien Kraus via Guix-patches via
2021-11-18  9:09     ` Ludovic Courtès
2021-11-18  9:17       ` Efraim Flashner [this message]
2021-11-18 13:18         ` Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BF396FC9-4391-4001-AFD1-937A5EBCB2C8@flashner.co.il \
    --to=efraim@flashner.co.il \
    --cc=51890@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    --cc=vivien@planete-kraus.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.