From: Arun Isaac <arunisaac@systemreboot.net>
To: guix-devel@gnu.org
Subject: zipbomb handling should not be done in url-fetch/zipbomb
Date: Fri, 16 Jun 2017 15:15:54 +0530 [thread overview]
Message-ID: <9f5ff0ec.AEAALfWcKw0AAAAAAAAAAAOtZhgAAAACwQwAAAAAAAW9WABZQ6jZ@mailjet.com> (raw)
* Proposal
zip bomb (zip archives without a top level directory) handling should
not be done in `url-fetch/zipbomb'. It should be implemented as a
boolean argument to the `unpack' phase.
Likewise for url-fetch/tarbomb as well.
* Rationale
I'm changing the download method of a few packages to url-fetch/zipbomb,
and the source gets downloaded again. This should not happen. It is the
same source archive after all. Why download another copy? In my
particular case, these source archives happen to be quite big (around
500 MB) as well.
The download method in source/origin/method should only be involved in
downloading. It should not handle how the downloaded source archive is
unpacked. That is the job of the `unpack' phase. url-fetch/zipbomb
unnecessarily duplicates the "unzip" command invocation.
* Feedback
WDYT?
next reply other threads:[~2017-06-16 9:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-16 9:45 Arun Isaac [this message]
2017-06-17 20:13 ` zipbomb handling should not be done in url-fetch/zipbomb Ludovic Courtès
2017-06-18 22:21 ` Eric Bavier
2017-06-20 18:49 ` Arun Isaac
2017-06-21 10:45 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f5ff0ec.AEAALfWcKw0AAAAAAAAAAAOtZhgAAAACwQwAAAAAAAW9WABZQ6jZ@mailjet.com \
--to=arunisaac@systemreboot.net \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.