From: Maxime Devos <maximedevos@telenet.be>
To: Vivien Kraus <vivien@planete-kraus.eu>, 50677@debbugs.gnu.org
Subject: bug#50677: [PATCH] Minetest basic_materials really depends on moreores
Date: Wed, 22 Sep 2021 19:41:33 +0200 [thread overview]
Message-ID: <9f186bbdf47037b1f2b1218b0cd73141fa29e140.camel@telenet.be> (raw)
In-Reply-To: <391c3b2b8b058845bc07630ac2cd96c06783227b.camel@planete-kraus.eu>
[-- Attachment #1: Type: text/plain, Size: 1795 bytes --]
Vivien Kraus schreef op wo 22-09-2021 om 18:46 [+0200]:
> + (define log-file (open-output-file "guix-test.log"))
> + (let loop ((has-errors? #f))
> + (let ((line (read-line port)))
> + (unless (eof-obj ect? line)
> + (write-line line log-file))
> + (match `(,line ,has-errors?)
> + (((? error? line) _)
> + (loop #t))
> + (((? stop?) #f)
> + (kill pid SIGINT)
> + (close-port port)
> + (waitpid pid))
> + (((? eof-object?) #f)
> + (error "minetest didn't start"))
> + (((or (? stop?) (? eof-object?)) #t)
'(close-port port)' is missing in this branch.
This is important if 'port' is buffered, to flush the buffers.
From a test at the Guile REPL, it appears ports from 'open-output-file'
are buffered.
> + (error "minetest stopped after an error happened, see source/guix_testworld/guix-test.log"))
This requires the user to do "--keep-failed". It would be more convenient
if the output of Minetest was send to current-output-port, that way the
errors can be read from the build log (possibly at <https://ci.guix.gnu.org/>).
Suggestion: don't keep guix-test.log, or only print errors, but rather
output all ouputs of "minetest" to (current-output-port).
Alternative suggestion (to make building less verbose when there are no errors):
this patch, but run "cat" or a guile equivalent thereof (maybe open-input-file
+ sendfile + stat:size) on guix-test.log when there are errors.
> + (((? string? line) has-error?)
> + (display line)
> + (newline)
> + (loop has-error?)))))))))
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2021-09-22 17:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-19 15:23 bug#50677: [PATCH] Minetest basic_materials really depends on moreores Vivien Kraus via Bug reports for GNU Guix
2021-09-19 17:40 ` Maxime Devos
2021-09-19 18:54 ` Vivien Kraus via Bug reports for GNU Guix
2021-09-19 18:59 ` Vivien Kraus via Bug reports for GNU Guix
2021-09-19 19:18 ` Maxime Devos
2021-09-19 19:11 ` Maxime Devos
2021-09-19 21:05 ` Vivien Kraus via Bug reports for GNU Guix
2021-09-22 16:46 ` Vivien Kraus via Bug reports for GNU Guix
2021-09-22 17:41 ` Maxime Devos [this message]
2021-09-22 18:04 ` Vivien Kraus via Bug reports for GNU Guix
2021-09-22 18:15 ` Maxime Devos
2021-09-22 18:37 ` Vivien Kraus via Bug reports for GNU Guix
2021-09-22 18:43 ` Maxime Devos
2021-10-14 15:14 ` Vivien Kraus via Bug reports for GNU Guix
2021-10-15 20:18 ` Maxime Devos
2021-10-16 15:32 ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f186bbdf47037b1f2b1218b0cd73141fa29e140.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=50677@debbugs.gnu.org \
--cc=vivien@planete-kraus.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.